Files
bot-bottle/tests/unit
didericis-claude f268f0b704
test / integration-docker (pull_request) Successful in 29s
test / stage-firecracker-inputs (pull_request) Successful in 2s
test / unit (pull_request) Successful in 34s
lint / lint (push) Failing after 43s
tracker-policy-pr / check-pr (pull_request) Successful in 25s
test / build-infra (pull_request) Successful in 3m46s
test / integration-firecracker (pull_request) Successful in 1m37s
test / coverage (pull_request) Failing after 1m56s
test / publish-infra (pull_request) Has been skipped
fix(login): narrow exception types and cover cleanup path
Replace `except Exception` (broad-exception-caught) with specific types:
- _save_credentials: `except OSError` (only IO errors can occur there)
- _post error handler: `except (OSError, ValueError)` (network + JSON)
- poll-loop: `except (OSError, ValueError)` (network + JSON)

All three were causing `pylint fail-under=10` failures; now scores 10/10.

Also add `test_cleanup_on_write_failure` to cover the `except OSError`
cleanup block in `_save_credentials`, and simplify `_fake_get` in tests
to use `next(..., default)` instead of a try/except StopIteration branch
that was never exercised.
2026-07-21 04:16:26 +00:00
..