test(firecracker): satisfy pyright on the new infra-VM tests
tracker-policy-pr / check-pr (pull_request) Successful in 18s
test / integration-docker (pull_request) Successful in 30s
test / unit (pull_request) Successful in 42s
lint / lint (push) Successful in 45s
test / integration-firecracker (pull_request) Successful in 44s
test / coverage (pull_request) Successful in 1m8s

Two lint fixes, both test-only (no effect on the infra artifact version):
- annotate the TestAdoptable / TestKillInfraFirecrackers helper params
  (reportMissingParameterType).
- test_docker_test_helpers: read __unittest_skip__ via getattr on the
  dynamically-built Case type, matching the sibling assertion — pyright can't
  see the attribute the skip decorator adds (reportAttributeAccessIssue).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A9qa3xoavjQScufDfZaXKR
This commit is contained in:
2026-07-19 01:31:06 -04:00
parent d1aec706e3
commit 0adbf25977
2 changed files with 3 additions and 3 deletions
+1 -1
View File
@@ -28,7 +28,7 @@ class TestSkipUnlessDockerOrFirecracker(unittest.TestCase):
):
decorated = skip_unless_docker_or_firecracker()(type("Case", (), {}))
self.assertTrue(decorated.__unittest_skip__)
self.assertTrue(getattr(decorated, "__unittest_skip__", False))
if __name__ == "__main__":
+2 -2
View File
@@ -219,7 +219,7 @@ class TestKillPidfile(unittest.TestCase):
class TestAdoptable(unittest.TestCase):
def _dir(self, td, *, key=True, version=None):
def _dir(self, td: str, *, key: bool = True, version: str | None = None) -> Path:
d = Path(td)
if key:
(d / "id_ed25519").write_text("k")
@@ -259,7 +259,7 @@ class TestAdoptable(unittest.TestCase):
class TestKillInfraFirecrackers(unittest.TestCase):
def _fake_proc(self, root, pid, comm, cmdline):
def _fake_proc(self, root: Path, pid: int, comm: str, cmdline: list[str]) -> None:
p = root / str(pid)
p.mkdir()
(p / "comm").write_text(comm + "\n")