didericis/bot-bottle
1
0
Fork 0
Code Issues 33 Pull Requests 9 Actions Packages Releases Wiki Activity

fix: quality cleanup - gateway shutdown diagnostics (chunk 7/11) #527

Closed
didericis-codex wants to merge 1 commits from fix/gateway-output-pump-shutdown into fix/gateway-request-boundaries
pull from: fix/gateway-output-pump-shutdown
merge into: didericis:fix/gateway-request-boundaries
Conversation 0 Commits 1 Files Changed 2
+34 -4
didericis-codex commented 2026-07-26 23:16:33 -04:00
Collaborator
Copy Link
Copy Source

Stacked on #526. Seventh quality-cleanup chunk tracked by #444 and PRD 0082.

Contains gateway child-output shutdown races without hiding real failures:

  • _pump treats OSError/ValueError from an already-closed child stream as normal completion.
  • The same exceptions on a stream that is not closed remain operator-visible and include the daemon name and exception type.
  • Direct regression tests cover both expected closure and unexpected I/O failure.

Final stack extension

  • #528 — authoritative resource identities and bounded artifact transfers.

Validation: The complete eleven-PR stack passes all 2,520 unit tests; full-repository Pyright reports 0 errors; git diff --check passes.

Refs #444.

Final stack extension

  • #530 — cleanup execution and mandatory authenticated-secret integrity.

Final stack extension

  • #531 — bounded heavy Git and cleanup operations.

Final stack extension

  • #532 — fail-closed shared database and gateway credential permissions.
Stacked on #526. Seventh quality-cleanup chunk tracked by #444 and PRD 0082. Contains gateway child-output shutdown races without hiding real failures: - `_pump` treats `OSError`/`ValueError` from an already-closed child stream as normal completion. - The same exceptions on a stream that is not closed remain operator-visible and include the daemon name and exception type. - Direct regression tests cover both expected closure and unexpected I/O failure. **Final stack extension** - #528 — authoritative resource identities and bounded artifact transfers. **Validation:** The complete eleven-PR stack passes all 2,520 unit tests; full-repository Pyright reports 0 errors; `git diff --check` passes. Refs #444. **Final stack extension** - #530 — cleanup execution and mandatory authenticated-secret integrity. **Final stack extension** - #531 — bounded heavy Git and cleanup operations. **Final stack extension** - #532 — fail-closed shared database and gateway credential permissions.
didericis force-pushed fix/gateway-output-pump-shutdown from 3df0c77c07 to cb95d15ec5 2026-07-26 23:39:36 -04:00 Compare
didericis-codex changed title from fix: quality cleanup - gateway shutdown diagnostics (chunk 7/7) to fix: quality cleanup - gateway shutdown diagnostics (chunk 7/8) 2026-07-26 23:42:02 -04:00
didericis force-pushed fix/gateway-output-pump-shutdown from cb95d15ec5 to 4bd42e363d 2026-07-26 23:56:00 -04:00 Compare
didericis-codex changed title from fix: quality cleanup - gateway shutdown diagnostics (chunk 7/8) to fix: quality cleanup - gateway shutdown diagnostics (chunk 7/9) 2026-07-27 00:02:57 -04:00
didericis force-pushed fix/gateway-output-pump-shutdown from 4bd42e363d to b7f503be29 2026-07-27 00:17:29 -04:00 Compare
didericis-codex changed title from fix: quality cleanup - gateway shutdown diagnostics (chunk 7/9) to fix: quality cleanup - gateway shutdown diagnostics (chunk 7/10) 2026-07-27 00:26:13 -04:00
didericis added 1 commit 2026-07-27 00:46:53 -04:00
fix(gateway): contain output pump shutdown races
test / image-input-builds (pull_request) Failing after 12m49s
Details
test / unit (pull_request) Has started running
Details
test / coverage (pull_request) Blocked by required conditions
Details
test / integration-docker (pull_request) Blocked by required conditions
Details
tracker-policy-pr / check-pr (pull_request) Successful in 13s
Details
fd295d4c14
didericis force-pushed fix/gateway-output-pump-shutdown from b7f503be29 to fd295d4c14 2026-07-27 00:46:53 -04:00 Compare
didericis-codex changed title from fix: quality cleanup - gateway shutdown diagnostics (chunk 7/10) to fix: quality cleanup - gateway shutdown diagnostics (chunk 7/11) 2026-07-27 00:49:47 -04:00
didericis-codex closed this pull request 2026-07-27 01:35:45 -04:00
Some checks are pending
test / image-input-builds (pull_request) Failing after 12m49s
Details
test / unit (pull_request) Has started running
Details
test / coverage (pull_request) Blocked by required conditions
Details
test / integration-docker (pull_request) Blocked by required conditions
Details
tracker-policy-pr / check-pr (pull_request) Successful in 13s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status/Needs Triage
Awaiting initial classification
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#527
Delete Branch "fix/gateway-output-pump-shutdown"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?