didericis/bot-bottle
1
0
Fork 0
Code Issues 32 Pull Requests 8 Actions Packages Releases Wiki Activity

fix: quality cleanup - authoritative resource identities (chunk 8/11) #528

Closed
didericis-codex wants to merge 1 commits from fix/authoritative-cleanup-identities into fix/gateway-output-pump-shutdown
pull from: fix/authoritative-cleanup-identities
merge into: didericis:fix/gateway-output-pump-shutdown
Conversation 0 Commits 1 Files Changed 8
+185 -51
didericis-codex commented 2026-07-26 23:40:15 -04:00
Collaborator
Copy Link
Copy Source

Stacked on #527. Eighth quality-cleanup chunk tracked by #444 and PRD 0082.

Closes the remaining authoritative-snapshot findings from the project-wide review:

  • Lossless Firecracker identities: process discovery reads PIDs from pgrep and NUL-delimited argv from /proc/<pid>/cmdline, preserving cache and config paths containing spaces. Enumeration and termination now share the same argv parser.
  • Fail-closed Docker cleanup: compose projects, prefixed containers, and prefixed networks all raise EnumerationError when Docker cannot provide an authoritative snapshot. Stopped-project state can no longer be classified from a fabricated empty project set.
  • Bounded artifact operations: Firecracker artifact pull, registry existence checks, uploads, and deletes use explicit 30-second network deadlines.
  • Durable requirements: PRD 0082 is updated in the root PR to describe these boundaries and honestly records the residual container-engine name-reuse limitation.

Validation: The complete eleven-PR stack passes all 2,520 unit tests; full-repository Pyright reports 0 errors; git diff --check passes.

Refs #444.

Final stack extension

  • #530 — cleanup execution and mandatory authenticated-secret integrity.

Final stack extension

  • #531 — bounded heavy Git and cleanup operations.

Final stack extension

  • #532 — fail-closed shared database and gateway credential permissions.
Stacked on #527. Eighth quality-cleanup chunk tracked by #444 and PRD 0082. Closes the remaining authoritative-snapshot findings from the project-wide review: - **Lossless Firecracker identities:** process discovery reads PIDs from `pgrep` and NUL-delimited argv from `/proc/<pid>/cmdline`, preserving cache and config paths containing spaces. Enumeration and termination now share the same argv parser. - **Fail-closed Docker cleanup:** compose projects, prefixed containers, and prefixed networks all raise `EnumerationError` when Docker cannot provide an authoritative snapshot. Stopped-project state can no longer be classified from a fabricated empty project set. - **Bounded artifact operations:** Firecracker artifact pull, registry existence checks, uploads, and deletes use explicit 30-second network deadlines. - **Durable requirements:** PRD 0082 is updated in the root PR to describe these boundaries and honestly records the residual container-engine name-reuse limitation. **Validation:** The complete eleven-PR stack passes all 2,520 unit tests; full-repository Pyright reports 0 errors; `git diff --check` passes. Refs #444. **Final stack extension** - #530 — cleanup execution and mandatory authenticated-secret integrity. **Final stack extension** - #531 — bounded heavy Git and cleanup operations. **Final stack extension** - #532 — fail-closed shared database and gateway credential permissions.
didericis force-pushed fix/authoritative-cleanup-identities from 3c97a9acac to 5b54c38ab6 2026-07-26 23:55:49 -04:00 Compare
didericis-codex changed title from fix: quality cleanup - authoritative resource identities (chunk 8/8) to fix: quality cleanup - authoritative resource identities (chunk 8/9) 2026-07-27 00:02:58 -04:00
didericis force-pushed fix/authoritative-cleanup-identities from 5b54c38ab6 to d29777bd96 2026-07-27 00:17:53 -04:00 Compare
didericis-codex changed title from fix: quality cleanup - authoritative resource identities (chunk 8/9) to fix: quality cleanup - authoritative resource identities (chunk 8/10) 2026-07-27 00:26:13 -04:00
didericis added 1 commit 2026-07-27 00:46:59 -04:00
fix(cleanup): use authoritative resource identities
test / integration-docker (pull_request) Has been cancelled
Details
test / image-input-builds (pull_request) Successful in 53s
Details
test / unit (pull_request) Successful in 59s
Details
test / coverage (pull_request) Has been skipped
Details
tracker-policy-pr / check-pr (pull_request) Failing after 12m23s
Details
f242733d15
didericis force-pushed fix/authoritative-cleanup-identities from d29777bd96 to f242733d15 2026-07-27 00:46:59 -04:00 Compare
didericis-codex changed title from fix: quality cleanup - authoritative resource identities (chunk 8/10) to fix: quality cleanup - authoritative resource identities (chunk 8/11) 2026-07-27 00:50:06 -04:00
didericis-codex closed this pull request 2026-07-27 01:35:50 -04:00
Some checks are pending
test / integration-docker (pull_request) Has been cancelled
Details
test / image-input-builds (pull_request) Successful in 53s
Details
test / unit (pull_request) Successful in 59s
Details
test / coverage (pull_request) Has been skipped
Details
tracker-policy-pr / check-pr (pull_request) Failing after 12m23s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status/Needs Triage
Awaiting initial classification
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#528
Delete Branch "fix/authoritative-cleanup-identities"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?