feat(dashboard): agent-scoped e/p, drop discover-and-prompt path #41

2026-05-26T01:50:41-04:00

didericis commented

2026-05-26 01:50:41 -04:00

Summary

PRD 0019 chunk 4 (the last one). The e (routes edit) and p (pipelock edit) keys now require an agent selection in the agents pane. Pressing them with the proposals pane focused, with no active agents, or with an out-of-range selection is a no-op with a status hint (no agent selected; Tab into the agents pane first).

The discover-and-prompt scaffolding inside _operator_edit_routes_flow / _operator_edit_allowlist_flow / _operator_edit_flow is gone. The flows take an ActiveAgent + required-service name; they refuse with a clear message when the bottle lacks the requested sidecar (e.g., routes edit against a bottle with no bottle.egress.routes declared, so no egress sidecar). The discover_egress_slugs + discover_pipelock_slugs + _discover_active_with_service helpers come out — they had no remaining callers.

Footer reflects the new model: [e/p] edit selected agent.

Status

451 unit tests pass (5 new for _selected_agent and the require-service guard)
One test pruned (TestDiscoverEgressSlugs.test_returns_empty_when_docker_unavailable) — covered the deleted helpers; the new agents-pane discovery path's empty-docker behavior is covered by discover_active_agents tests already

## Summary PRD 0019 chunk 4 (the last one). The `e` (routes edit) and `p` (pipelock edit) keys now require an agent selection in the agents pane. Pressing them with the proposals pane focused, with no active agents, or with an out-of-range selection is a no-op with a status hint (`no agent selected; Tab into the agents pane first`). The discover-and-prompt scaffolding inside `_operator_edit_routes_flow` / `_operator_edit_allowlist_flow` / `_operator_edit_flow` is gone. The flows take an `ActiveAgent` + required-service name; they refuse with a clear message when the bottle lacks the requested sidecar (e.g., `routes edit` against a bottle with no `bottle.egress.routes` declared, so no egress sidecar). The `discover_egress_slugs` + `discover_pipelock_slugs` + `_discover_active_with_service` helpers come out — they had no remaining callers. Footer reflects the new model: `[e/p] edit selected agent`. ## Status - 451 unit tests pass (5 new for `_selected_agent` and the require-service guard) - One test pruned (`TestDiscoverEgressSlugs.test_returns_empty_when_docker_unavailable`) — covered the deleted helpers; the new agents-pane discovery path's empty-docker behavior is covered by `discover_active_agents` tests already

didericis added 1 commit 2026-05-26 01:50:42 -04:00

feat(dashboard): agent-scoped e/p, drop discover-and-prompt path

test / unit (pull_request) Successful in 17s

Details

test / integration (pull_request) Successful in 1m6s

Details

7b29c81f27

PRD 0019 chunk 4 (final). The `e` (routes edit) and `p` (pipelock
edit) keys now require an agent selection in the agents pane.
Pressing them with the proposals pane focused, with no active
agents, or with an out-of-range selection is a no-op with a
status hint ("no agent selected; Tab into the agents pane first").

The discover-and-prompt scaffolding inside
`_operator_edit_routes_flow` / `_operator_edit_allowlist_flow` /
`_operator_edit_flow` is gone. The flows now take an `ActiveAgent`
+ required-service name; they refuse with a clear message when
the bottle lacks the requested sidecar (e.g., `routes edit`
against a bottle with no `bottle.egress.routes` declared). The
`discover_egress_slugs` + `discover_pipelock_slugs` +
`_discover_active_with_service` helpers come out — they had no
remaining callers.

Footer now reads `[e/p] edit selected agent`.

didericis merged commit 11d5bf1489 into main

2026-05-26 01:52:40 -04:00

didericis deleted branch chunk-4-agent-scoped-edits

2026-05-26 01:53:04 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: didericis/bot-bottle#41