didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

PRD 0043: sidecar pipe lifecycle cleanup #146

Merged
didericis merged 3 commits from prd-0043-sidecar-pipe-lifecycle into main 2026-06-02 11:53:15 -04:00
Conversation 1 Commits 3 Files Changed 3
+87 -1
didericis-claude commented 2026-06-02 10:29:00 -04:00
Collaborator
Copy Link
Copy Source

Closes #140.

PRD: https://gitea.dideric.is/didericis/bot-bottle/src/branch/prd-0043-sidecar-pipe-lifecycle/docs/prds/0043-sidecar-pipe-lifecycle.md

Summary

  • Explicitly close child stdout pipe file descriptors in the _Supervisor restart and shutdown paths
  • Enable ResourceWarning as a test error to catch any remaining leaks
  • No change to signal handling or exit-code contract from PRD 0034

Changes (1 commit)

  • docs/prds/0043-sidecar-pipe-lifecycle.md — add PRD 0043 (Draft)
Closes #140. PRD: https://gitea.dideric.is/didericis/bot-bottle/src/branch/prd-0043-sidecar-pipe-lifecycle/docs/prds/0043-sidecar-pipe-lifecycle.md ## Summary - Explicitly close child stdout pipe file descriptors in the `_Supervisor` restart and shutdown paths - Enable `ResourceWarning` as a test error to catch any remaining leaks - No change to signal handling or exit-code contract from PRD 0034 ## Changes (1 commit) - `docs/prds/0043-sidecar-pipe-lifecycle.md` — add PRD 0043 (Draft)
didericis approved these changes 2026-06-02 11:09:17 -04:00
didericis added 3 commits 2026-06-02 11:48:29 -04:00
docs: add PRD 0043 19ebcd52a1
fix: close child stdout pipes on restart and loop convergence (PRD 0043) 5a2011c48f 
Closes #140. In restart_daemon, the old process's stdout pipe was never
explicitly closed after p.wait() returned, leaking the fd until the
supervisor object was GC'd. Similarly, when the watch loop converged
(all children dead), no pipe was closed. Both paths now call
p.stdout.close() immediately after the process is confirmed exited.
Tests enforce this with warnings.simplefilter("error", ResourceWarning)
in TestSupervisor.setUp.
docs: mark PRD 0043 Active
test / unit (pull_request) Successful in 34s
Details
test / integration (pull_request) Successful in 43s
Details
test / unit (push) Successful in 34s
Details
test / integration (push) Successful in 41s
Details
4fdf354b4f
didericis force-pushed prd-0043-sidecar-pipe-lifecycle from 8ca1ede4ec to 4fdf354b4f 2026-06-02 11:48:29 -04:00 Compare
didericis merged commit 4fdf354b4f into main 2026-06-02 11:53:15 -04:00
didericis deleted branch prd-0043-sidecar-pipe-lifecycle 2026-06-02 11:53:15 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
didericis
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#146
Delete Branch "prd-0043-sidecar-pipe-lifecycle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?