didericis (claude) didericis-claude
  • Joined on 2026-05-27
didericis-claude commented on pull request didericis/bot-bottle#121 2026-06-02 01:50:53 -04:00
PRD 0031: Provisioned-wins merge + EgressRoute inherits Route

RE didericis/bot-bottle#121 (comment)

The blocker is that the addon runs in a stdlib-only environment inside the container — bot_bottle is never…

didericis-claude commented on pull request didericis/bot-bottle#121 2026-06-02 01:23:12 -04:00
PRD 0031: Provisioned-wins merge + EgressRoute inherits Route

RE didericis/bot-bottle#121 (comment)

Got it — expanding scope and revising the merge design. Here's my read before I update the PRD:

**Provisioned-wins…

didericis-claude created pull request didericis/bot-bottle#121 2026-06-02 01:09:12 -04:00
PRD 0031: Split _merge_provider_route into named case helpers
didericis-claude opened issue didericis/bot-bottle#120 2026-06-02 01:07:04 -04:00
Refactor _merge_provider_route: split five-case branch into named helpers
didericis-claude commented on pull request didericis/bot-bottle#119 2026-06-02 00:48:33 -04:00
PRD 0030: Deduplicate egress token resolution across backends

RE didericis/bot-bottle#119 (comment)

Good call — the sentinel skip was a code smell. Here is the revised plan:

  • Add provisioned_env: dict[str, str]
didericis-claude commented on pull request didericis/bot-bottle#119 2026-06-02 00:39:45 -04:00
PRD 0030: Deduplicate egress token resolution across backends

Re: egress_resolve_token_values_with_provider — the reason CODEX_HOST_CREDENTIAL_TOKEN_REF exists as a sentinel is that egress_resolve_token_values assumes every token_ref is an…

didericis-claude created pull request didericis/bot-bottle#119 2026-06-02 00:26:36 -04:00
PRD 0030: Deduplicate egress token resolution across backends
didericis-claude opened issue didericis/bot-bottle#118 2026-06-02 00:16:47 -04:00
Deduplicate egress token resolution across backends
didericis-claude commented on issue didericis/bot-bottle#117 2026-06-02 00:12:12 -04:00
Complexity hotspots in launch, egress, and auth paths

Independent Code Review — Hotspot Assessment

Cloned the repo and read the flagged files plus several others. Here's where I agree, disagree, and what I think was missed.


Where I…

didericis-claude commented on pull request didericis/bot-bottle#115 2026-06-01 21:34:34 -04:00
PRD 0029: provision egress routes via AgentProvisionPlan

Done — api.anthropic.com is now always emitted as a tls_passthrough route for Claude (same pattern as Codex + the OpenAI hosts). Auth scheme and token_ref only populated when auth_token is…

didericis-claude commented on pull request didericis/bot-bottle#115 2026-06-01 21:16:45 -04:00
PRD 0029: provision egress routes via AgentProvisionPlan

Will expand the branch to include it. I'll update the PRD to reflect the broader scope, implement agent_provider.auth_token, have the Claude provisioner inject the api.anthropic.com route from…

didericis-claude commented on pull request didericis/bot-bottle#115 2026-06-01 21:14:28 -04:00
PRD 0029: provision egress routes via AgentProvisionPlan

Got it — so the end state is: agent_provider.auth_token: BOT_BOTTLE_CLAUDE_OAUTH_TOKEN in the manifest drives the provisioner to inject a provider-owned api.anthropic.com route (Bearer,…

didericis-claude commented on pull request didericis/bot-bottle#115 2026-06-01 21:09:24 -04:00
PRD 0029: provision egress routes via AgentProvisionPlan

Re: placeholder_env_for (#issuecomment-941) — agree, wrong abstraction. Will remove it. One option to fix print_util without template-switching: add a hidden_env_names: frozenset[str] field…

didericis-claude commented on pull request didericis/bot-bottle#115 2026-06-01 20:52:21 -04:00
PRD 0029: provision egress routes via AgentProvisionPlan

Agreed — the has_provider_auth detection and placeholder injection is provider logic that should live in agent_provision_plan, not in each backend. Moving it there will also let us drop…

didericis-claude created pull request didericis/bot-bottle#115 2026-06-01 19:31:29 -04:00
PRD 0029: provision egress routes via AgentProvisionPlan
didericis-claude commented on pull request didericis/bot-bottle#110 2026-06-01 19:27:47 -04:00
PRD 0029: Codex host credentials through egress

Implemented in b79b490 on prd-0029-egress-routes-via-agent-provision-plan. Summary of what changed:

  • EgressRoute gains tls_passthrough: bool. egress_manifest_routes lifts the manifest…
didericis-claude commented on pull request didericis/bot-bottle#110 2026-06-01 19:11:25 -04:00
PRD 0029: Codex host credentials through egress

RE: didericis/bot-bottle#110 (comment)

Agreed on the direction. Concrete shape I have in mind:

  1. Add egress_routes: tuple[EgressRoute, ...] to `AgentProvi…
didericis-claude commented on pull request didericis/bot-bottle#110 2026-06-01 19:06:01 -04:00
PRD 0029: Codex host credentials through egress

Fair — this is the same provider-specific branching the rest of the PR moved out of the backends.

The root cause is that EgressRoute has no tls_passthrough field, so `pipelock_effective_tls_p…

didericis-claude commented on pull request didericis/bot-bottle#114 2026-05-29 23:51:47 -04:00
fix(git-gate): bound daemon client sessions

Replying to didericis/bot-bottle#114 (comment):

git http-backend is the built-in — the Python class is a CGI adapter around it, not a custom git…