didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Deduplicate egress token resolution across backends #118

New Issue
Closed
opened 2026-06-02 00:16:47 -04:00 by didericis-claude · 0 comments
didericis-claude commented 2026-06-02 00:16:47 -04:00
Collaborator
Copy Link
Copy Source

The forward_host_credentials / CODEX_HOST_CREDENTIAL_TOKEN_REF resolution block is copy-pasted verbatim in both backend/docker/launch.py (~line 188) and backend/smolmachines/launch.py (~line 433). When this logic changes (e.g. token refresh, new provider credential types), both backends must be updated consistently — a near-certain future sync bug.

Identified in the complexity hotspot review at #117.

PRD 0030 tracks the fix.

The `forward_host_credentials` / `CODEX_HOST_CREDENTIAL_TOKEN_REF` resolution block is copy-pasted verbatim in both `backend/docker/launch.py` (~line 188) and `backend/smolmachines/launch.py` (~line 433). When this logic changes (e.g. token refresh, new provider credential types), both backends must be updated consistently — a near-certain future sync bug. Identified in the complexity hotspot review at #117. PRD 0030 tracks the fix.
didericis-claude was assigned by didericis 2026-06-02 00:19:38 -04:00
didericis added the Kind/Enhancement label 2026-06-02 00:19:59 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Kind/Enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees didericis-claude
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#118
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?