didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Simplify egress route merge and consolidate Route types #120

New Issue
Closed
opened 2026-06-02 01:07:03 -04:00 by didericis-claude · 0 comments
didericis-claude commented 2026-06-02 01:07:03 -04:00
Collaborator
Copy Link
Copy Source

Tracked from the complexity hotspot review in #117. Two remaining open tasks from that review:

1. _merge_provider_route branching — five distinct outcomes (append-new, upgrade-bare, no-op, tls-passthrough upgrade, conflict-die) collapsed into one function with interleaved conditions and in-place index rewrites. The root cause: the merge tries to be cooperative when the actual intended hierarchy is provisioned routes win outright.

2. Route type fragmentation — EgressRoute (host-side) and egress_addon_core.Route (sidecar-side) are separate types with overlapping fields and no explicit mapping between them. egress_render_routes spells out the field list inline with no reference to the addon parser, so divergence is silent until runtime.

See PRD 0031 for the full design.

Tracked from the complexity hotspot review in #117. Two remaining open tasks from that review: **1. `_merge_provider_route` branching** — five distinct outcomes (append-new, upgrade-bare, no-op, tls-passthrough upgrade, conflict-die) collapsed into one function with interleaved conditions and in-place index rewrites. The root cause: the merge tries to be cooperative when the actual intended hierarchy is provisioned routes win outright. **2. Route type fragmentation** — `EgressRoute` (host-side) and `egress_addon_core.Route` (sidecar-side) are separate types with overlapping fields and no explicit mapping between them. `egress_render_routes` spells out the field list inline with no reference to the addon parser, so divergence is silent until runtime. See PRD 0031 for the full design.
didericis added the Kind/Enhancement label 2026-06-02 01:25:55 -04:00
didericis-claude changed title from Refactor _merge_provider_route: split five-case branch into named helpers to Simplify egress route merge and consolidate Route types 2026-06-02 01:26:34 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Kind/Enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#120
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?