didericis
ce744a85c4
tracker-policy-pr / check-pr (pull_request) Successful in 11s
test / integration-docker (pull_request) Successful in 17s
test / unit (pull_request) Successful in 49s
lint / lint (push) Failing after 2m49s
test / integration-firecracker (pull_request) Successful in 3m35s
test / coverage (pull_request) Successful in 18s
test / publish-infra (pull_request) Has been skipped
Group the gateway's data-plane modules into three service sub-packages mirroring the host-side trio (bot_bottle.egress / .supervisor / .git_gate): gateway/egress/ addon_core, addon, dlp_config, dlp_detectors gateway/supervisor/ server (was supervise_server) gateway/git_gate/ render, http_backend Prefix-stripped filenames now that the package namespaces them; each sub-package has a thin docstring __init__ (no eager imports, cheap leaf loads). The two cross-cutting files stay at the gateway root: policy_resolver (shared per-client lookup) and gateway_init, renamed to bootstrap now that gateway/ already namespaces it. Updated all importers (bot_bottle + tests), the in-VM/container `-m` launch strings, the Dockerfile.gateway addon shim + ENTRYPOINT, and the five gateway entries in scripts/critical-modules.txt. Full unit suite green (2243). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
68 lines
2.4 KiB
Python
68 lines
2.4 KiB
Python
"""Unit: consolidated per-bottle git-gate provisioning render (PRD 0070)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import unittest
|
|
|
|
from bot_bottle.gateway.git_gate.render import (
|
|
GitGateUpstream,
|
|
git_gate_render_entrypoint,
|
|
git_gate_render_provision,
|
|
)
|
|
|
|
|
|
def _ups(*names: str) -> tuple[GitGateUpstream, ...]:
|
|
return tuple(
|
|
GitGateUpstream(
|
|
name=n,
|
|
upstream_url=f"ssh://git@github.com/x/{n}.git",
|
|
upstream_host="github.com",
|
|
upstream_port="22",
|
|
identity_file="",
|
|
known_host_key="",
|
|
)
|
|
for n in names
|
|
)
|
|
|
|
|
|
class TestProvisionRender(unittest.TestCase):
|
|
def test_namespaces_repos_and_creds_by_bottle_id(self) -> None:
|
|
script = git_gate_render_provision("bottleab12", _ups("foo"))
|
|
self.assertIn("repo=/git/bottleab12/${name}.git", script)
|
|
self.assertIn("keyfile=/git-gate/creds/bottleab12/${name}-key", script)
|
|
self.assertIn("mkdir -p /git/bottleab12", script)
|
|
|
|
def test_one_init_repo_call_per_upstream(self) -> None:
|
|
script = git_gate_render_provision("b1", _ups("foo", "bar"))
|
|
calls = [l for l in script.splitlines() if l.startswith("init_repo ")]
|
|
self.assertEqual(2, len(calls))
|
|
|
|
def test_provision_does_not_start_the_daemon(self) -> None:
|
|
# The shared gateway already serves; provisioning is init-only.
|
|
self.assertNotIn("git daemon", git_gate_render_provision("b1", _ups("foo")))
|
|
|
|
def test_installs_pre_receive_hook(self) -> None:
|
|
script = git_gate_render_provision("b1", _ups("foo"))
|
|
self.assertIn("install -m 755 /etc/git-gate/pre-receive", script)
|
|
|
|
def test_rejects_unsafe_bottle_id(self) -> None:
|
|
for bad in ("../etc", "a/b", "a b", "a;rm", ""):
|
|
with self.assertRaises(ValueError):
|
|
git_gate_render_provision(bad, _ups("foo"))
|
|
|
|
|
|
class TestEntrypointUnchanged(unittest.TestCase):
|
|
"""The shared `_git_gate_init_repo_fn` refactor must not alter the
|
|
single-tenant daemon entrypoint's output."""
|
|
|
|
def test_entrypoint_still_single_tenant_flat(self) -> None:
|
|
script = git_gate_render_entrypoint(_ups("foo"))
|
|
self.assertIn("repo=/git/${name}.git", script) # flat, not namespaced
|
|
self.assertIn("keyfile=/git-gate/creds/${name}-key", script)
|
|
self.assertIn("--base-path=/git", script)
|
|
self.assertIn("exec git daemon", script)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|