didericis
c07ebca867
Delete the smolmachines backend (the whole bot_bottle/backend/smolmachines package and its tests). It had fatal Linux issues (TSI networking under sustained use, exec-channel contention, no SIGWINCH) and is superseded by the Firecracker backend (issue #342). Backend selection now: - default is macos-container on macOS, firecracker on KVM-capable Linux hosts, and docker as the last resort (was smolmachines). - firecracker is selected on a KVM host even when the `firecracker` binary isn't installed, so start routes through its preflight and prints an install pointer (same UX as require_container), instead of silently falling back. Split is_host_capable() (Linux + KVM) out of is_available() (adds the binary check) to drive this. Retarget the cross-backend tests (parity, print-parity, prepare, workspace, freezer, selection) from smolmachines to firecracker rather than dropping the coverage. Remove docker.util.image_id/save, which only smolmachines used. Update README/AGENTS/example bottles and stale comments; historical docs/prds are left as a point-in-time record. BREAKING: BOT_BOTTLE_BACKEND=smolmachines now errors as unknown. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBMWTEtQdJ4W5UrWuLHCck
144 lines
4.5 KiB
Python
144 lines
4.5 KiB
Python
"""Unit: cli.py commit command."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from bot_bottle.cli.commit import cmd_commit
|
|
from bot_bottle import supervise
|
|
from bot_bottle import bottle_state
|
|
from bot_bottle.backend.freeze import CommitCancelled
|
|
|
|
|
|
class _FakeHomeMixin:
|
|
def _setup_fake_home(self):
|
|
self._tmp = tempfile.TemporaryDirectory(prefix="cli-commit-test.")
|
|
original = supervise.bot_bottle_root
|
|
|
|
def fake_root() -> Path:
|
|
return Path(self._tmp.name) / ".bot-bottle"
|
|
|
|
supervise.bot_bottle_root = fake_root # type: ignore[assignment]
|
|
self._restore = lambda: setattr(supervise, "bot_bottle_root", original)
|
|
|
|
def _teardown_fake_home(self):
|
|
self._restore()
|
|
self._tmp.cleanup()
|
|
|
|
|
|
class TestCmdCommitSlugArg(_FakeHomeMixin, unittest.TestCase):
|
|
"""cmd_commit with an explicit slug delegates to get_freezer."""
|
|
|
|
def setUp(self):
|
|
self._setup_fake_home()
|
|
|
|
def tearDown(self):
|
|
self._teardown_fake_home()
|
|
|
|
def _write_meta(self, slug: str, backend: str) -> None:
|
|
bottle_state.write_metadata(bottle_state.BottleMetadata(
|
|
identity=slug, agent_name="dev", cwd="", copy_cwd=False,
|
|
started_at="t", backend=backend,
|
|
))
|
|
|
|
def test_commits_docker_bottle(self):
|
|
slug = "dev-abc12"
|
|
self._write_meta(slug, "docker")
|
|
|
|
with patch("bot_bottle.cli.commit.get_freezer") as mock_gf:
|
|
mock_freezer = MagicMock()
|
|
mock_gf.return_value = mock_freezer
|
|
rc = cmd_commit([slug])
|
|
|
|
self.assertEqual(0, rc)
|
|
mock_gf.assert_called_once_with("docker")
|
|
mock_freezer.commit_slug.assert_called_once_with(slug)
|
|
|
|
def test_empty_backend_passed_to_get_freezer(self):
|
|
"""Old state dirs without a backend field pass '' to get_freezer."""
|
|
slug = "dev-abc12"
|
|
self._write_meta(slug, "")
|
|
|
|
with patch("bot_bottle.cli.commit.get_freezer") as mock_gf:
|
|
mock_freezer = MagicMock()
|
|
mock_gf.return_value = mock_freezer
|
|
rc = cmd_commit([slug])
|
|
|
|
self.assertEqual(0, rc)
|
|
mock_gf.assert_called_once_with("")
|
|
|
|
def test_commits_macos_container_bottle(self):
|
|
slug = "dev-abc12"
|
|
self._write_meta(slug, "macos-container")
|
|
|
|
with patch("bot_bottle.cli.commit.get_freezer") as mock_gf:
|
|
mock_freezer = MagicMock()
|
|
mock_gf.return_value = mock_freezer
|
|
rc = cmd_commit([slug])
|
|
|
|
self.assertEqual(0, rc)
|
|
mock_gf.assert_called_once_with("macos-container")
|
|
mock_freezer.commit_slug.assert_called_once_with(slug)
|
|
|
|
def test_commits_firecracker_bottle(self):
|
|
slug = "dev-abc12"
|
|
self._write_meta(slug, "firecracker")
|
|
|
|
with patch("bot_bottle.cli.commit.get_freezer") as mock_gf:
|
|
mock_freezer = MagicMock()
|
|
mock_gf.return_value = mock_freezer
|
|
rc = cmd_commit([slug])
|
|
|
|
self.assertEqual(0, rc)
|
|
mock_gf.assert_called_once_with("firecracker")
|
|
|
|
def test_returns_zero_on_commit_cancelled(self):
|
|
slug = "dev-abc12"
|
|
self._write_meta(slug, "macos-container")
|
|
|
|
with patch("bot_bottle.cli.commit.get_freezer") as mock_gf:
|
|
mock_freezer = MagicMock()
|
|
mock_freezer.commit_slug.side_effect = CommitCancelled
|
|
mock_gf.return_value = mock_freezer
|
|
rc = cmd_commit([slug])
|
|
|
|
self.assertEqual(0, rc)
|
|
|
|
|
|
class TestCmdCommitNoActiveBottles(_FakeHomeMixin, unittest.TestCase):
|
|
def setUp(self):
|
|
self._setup_fake_home()
|
|
|
|
def tearDown(self):
|
|
self._teardown_fake_home()
|
|
|
|
def test_dies_when_no_active_bottles_and_no_slug(self):
|
|
with patch(
|
|
"bot_bottle.cli.commit.enumerate_active_agents", return_value=[],
|
|
), patch(
|
|
"bot_bottle.cli.commit.die", side_effect=SystemExit("die"),
|
|
) as mock_die:
|
|
with self.assertRaises(SystemExit):
|
|
cmd_commit([])
|
|
|
|
mock_die.assert_called_once()
|
|
|
|
def test_returns_zero_when_picker_cancelled(self):
|
|
active = MagicMock()
|
|
active.slug = "dev-abc12"
|
|
with patch(
|
|
"bot_bottle.cli.commit.enumerate_active_agents", return_value=[active],
|
|
), patch(
|
|
"bot_bottle.cli.commit.tui.filter_select", return_value=None,
|
|
):
|
|
rc = cmd_commit([])
|
|
|
|
self.assertEqual(0, rc)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|