fix(manifest): avoid KeyError when override bottle has repos absent from base #464

Merged
didericis merged 2 commits from fix/457-merge-bottles-git-repo-keyerror into main 2026-07-23 18:33:01 -04:00

2 Commits

Author SHA1 Message Date
didericis-claude f3437528d6 test: annotate _git_repo helper to satisfy pyright strict mode
test / integration-docker (pull_request) Successful in 17s
lint / lint (push) Successful in 55s
test / unit (pull_request) Successful in 1m44s
tracker-policy-pr / check-pr (pull_request) Successful in 7s
test / integration-firecracker (pull_request) Successful in 3m24s
test / coverage (pull_request) Successful in 16s
test / publish-infra (pull_request) Has been skipped
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-07-23 22:25:28 +00:00
didericis-claude 7b9b1c6312 fix(manifest): avoid KeyError when override bottle has repos absent from base
test / integration-docker (pull_request) Successful in 19s
test / unit (pull_request) Successful in 38s
lint / lint (push) Failing after 2m47s
test / integration-firecracker (pull_request) Successful in 3m17s
test / coverage (pull_request) Successful in 44s
test / publish-infra (pull_request) Has been skipped
tracker-policy-pr / check-pr (pull_request) Failing after 12m13s
merge_bottles_runtime used .get(n, base_repos_by_name[n]) which eagerly
evaluates the default, crashing when a repo exists only in the override
bottle. Replaced with a conditional expression so the base lookup only
runs when needed.

Adds three regression tests covering override-only, base-only, and
name-collision cases.

Closes #457

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-07-23 22:17:32 +00:00