didericis/bot-bottle
1
0
Fork 0
Code Issues 36 Pull Requests 5 Actions Packages Releases Wiki Activity

fix(ci): use absolute paths for coverage artifact upload/download #448

Closed
didericis-claude wants to merge 2 commits from fix/ci-coverage-artifact-paths into main
pull from: fix/ci-coverage-artifact-paths
merge into: didericis:main
Conversation 0 Commits 2 Files Changed 4
+241 -120
didericis-claude commented 2026-07-21 00:53:45 -04:00
Collaborator
Copy Link
Copy Source

Closes #446.

Summary

The delphi-ci runner's upload-artifact@v3 and download-artifact@v3 actions resolve relative paths from a different CWD than run: shell steps. This means .coverage.unit, .coverage.docker, and .coverage.firecracker were never found by the upload action even though coverage run and coverage report could see them correctly.

Changing all six paths to use ${{ github.workspace }} gives the JS action an absolute path, removing the CWD dependency.

Merge rule(s)

Squash.

Closes #446. ## Summary The delphi-ci runner's `upload-artifact@v3` and `download-artifact@v3` actions resolve relative paths from a different CWD than `run:` shell steps. This means `.coverage.unit`, `.coverage.docker`, and `.coverage.firecracker` were never found by the upload action even though `coverage run` and `coverage report` could see them correctly. Changing all six paths to use `${{ github.workspace }}` gives the JS action an absolute path, removing the CWD dependency. ## Merge rule(s) Squash.
didericis-claude added 2 commits 2026-07-21 00:53:46 -04:00
ci: artifact-based coverage and local Firecracker candidate flow
test / integration-docker (pull_request) Successful in 12s
Details
tracker-policy-pr / check-pr (pull_request) Successful in 8s
Details
test / unit (pull_request) Successful in 33s
Details
test / integration-firecracker (pull_request) Successful in 3m13s
Details
test / coverage (pull_request) Failing after 1m45s
Details
test / publish-infra (pull_request) Has been skipped
Details
5940b75bb7 
Each test job now runs once under coverage and uploads a small .coverage.*
artifact. The coverage job combines them on ubuntu-latest — no test reruns,
no KVM dependency. The infra candidate is built directly on the KVM runner,
eliminating the build-infra job and the ~70 s upload + ~83 s combined
download. For PRs, no rootfs artifact is transferred at all. Main-branch
pushes upload the tested rootfs and matching dropbear so publish-infra
publishes the byte-identical artifact. relative_files = True in .coveragerc
lets coverage files from different runners combine without path remapping.

Closes #446
fix(ci): use absolute github.workspace paths for coverage artifact upload/download
test / integration-docker (pull_request) Successful in 13s
Details
tracker-policy-pr / check-pr (pull_request) Successful in 15s
Details
test / unit (pull_request) Successful in 31s
Details
test / integration-firecracker (pull_request) Successful in 3m11s
Details
test / coverage (pull_request) Failing after 1m44s
Details
test / publish-infra (pull_request) Has been skipped
Details
c527841d55 
The delphi-ci runner resolves relative paths in upload-artifact and
download-artifact from a different CWD than run: shell steps, so
'.coverage.unit' etc. were never found. Using ${{ github.workspace }}
gives an absolute path that does not depend on the JS action's CWD.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
didericis-claude closed this pull request 2026-07-21 00:56:14 -04:00
Some optional checks failed
test / integration-docker (pull_request) Successful in 13s
Details
tracker-policy-pr / check-pr (pull_request) Successful in 15s
Required
Details
test / unit (pull_request) Successful in 31s
Details
test / integration-firecracker (pull_request) Successful in 3m11s
Details
test / coverage (pull_request) Failing after 1m44s
Details
test / publish-infra (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status/Needs Triage
Awaiting initial classification
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#448
Delete Branch "fix/ci-coverage-artifact-paths"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?