didericis/bot-bottle
1
0
Fork 0
Code Issues 37 Pull Requests 4 Actions Packages Releases Wiki Activity

test(gateway-image): probe package imports, not pre-refactor flat modules #430

Merged
didericis merged 1 commits from fix-gateway-image-test-imports into main 2026-07-20 14:36:51 -04:00
Conversation 0 Commits 1 Files Changed 1
+4 -5
didericis commented 2026-07-20 13:40:24 -04:00
Owner
Copy Link
Copy Source

Closes #429.

test_python_imports_supervise_module probed the gateway image with import supervise; import supervise_server — the flat sibling modules 5ad3449 replaced with the installed bot_bottle package. Run against the current image it fails with ModuleNotFoundError: No module named 'supervise'.

It survived because the whole TestGatewayImage class carries a GITEA_ACTIONS skip (interactive-only, the build pulls a large base), so CI never executes it.

Verification

All 4 tests in the class pass against a freshly built gateway image locally.

Whether this class should run in CI at all is left alone here — that overlaps #414 and #426.

Closes #429. `test_python_imports_supervise_module` probed the gateway image with `import supervise; import supervise_server` — the flat sibling modules `5ad3449` replaced with the installed `bot_bottle` package. Run against the current image it fails with `ModuleNotFoundError: No module named 'supervise'`. It survived because the whole `TestGatewayImage` class carries a `GITEA_ACTIONS` skip (interactive-only, the build pulls a large base), so CI never executes it. ## Verification All 4 tests in the class pass against a freshly built gateway image locally. Whether this class should run in CI at all is left alone here — that overlaps #414 and #426.
didericis added 1 commit 2026-07-20 13:40:25 -04:00
test(gateway-image): probe package imports, not pre-refactor flat modules
test / stage-firecracker-inputs (pull_request) Successful in 3s
Details
test / integration-docker (pull_request) Successful in 10s
Details
tracker-policy-pr / check-pr (pull_request) Successful in 12s
Details
test / unit (pull_request) Successful in 1m31s
Details
test / build-infra (pull_request) Successful in 3m45s
Details
test / integration-firecracker (pull_request) Successful in 1m34s
Details
test / coverage (pull_request) Successful in 1m59s
Details
test / publish-infra (pull_request) Has been skipped
Details
test / stage-firecracker-inputs (push) Successful in 3s
Details
test / integration-docker (push) Successful in 16s
Details
Update Quality Badges / update-badges (push) Failing after 42s
Details
lint / lint (push) Successful in 53s
Details
test / unit (push) Successful in 1m35s
Details
test / build-infra (push) Successful in 3m30s
Details
test / integration-firecracker (push) Successful in 1m46s
Details
test / coverage (push) Successful in 2m1s
Details
test / publish-infra (push) Successful in 2m14s
Details
2de223a33b 
test_python_imports_supervise_module probed the image with
`import supervise; import supervise_server`, the flat sibling modules that
5ad3449 replaced. They now live in the installed package, so the test fails
with ModuleNotFoundError when actually run.

It went unnoticed because the whole class carries a GITEA_ACTIONS skip — it
is interactive-only, so CI never executes it.

All 4 tests in the class now pass against a freshly built gateway image.

Closes #429.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
didericis merged commit 2de223a33b into main 2026-07-20 14:36:51 -04:00
didericis deleted branch fix-gateway-image-test-imports 2026-07-20 14:36:54 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status/Needs Triage
Awaiting initial classification
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#430
Delete Branch "fix-gateway-image-test-imports"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?