didericis/bot-bottle
1
0
Fork 0
Code Issues 37 Pull Requests 4 Actions Packages Releases Wiki Activity

fix(macos-container): launch gateway as a module, not /app/gateway_init.py #428

Merged
didericis merged 1 commits from fix-gateway-package-paths into main 2026-07-20 14:58:35 -04:00
Conversation 0 Commits 1 Files Changed 2
+4 -2
didericis commented 2026-07-20 13:39:20 -04:00
Owner
Copy Link
Copy Source

Closes #427.

bot_bottle/backend/macos_container/infra.py spawned the gateway supervisor as python3 /app/gateway_init.py. 5ad3449 moved bot_bottle into a pip-installed package, so that file no longer exists — the supervisor never started, mitmdump never generated its CA, and bot-bottle start died downstream with GatewayError: gateway CA not available, which points at TLS rather than at the supervisor.

Same defect 127ba49 fixed for firecracker. It survived on macOS because CI has no Apple Container runner (#426).

test_macos_infra asserted the substring "gateway_init.py", which the broken path satisfies, so it stayed green. Tightened to the module form, matching the assertion 127ba49 already made in test_firecracker_infra_vm.

Verification

Verified end to end on the macos-container backend: gateway image builds, CA is generated (fingerprint printed), agent registers, supervise MCP is wired, and a headless bottle runs a prompt to completion and exits 0.

Full unit suite: 1879 passing.

Note

This branch originally also carried fixes for pyproject.toml, Dockerfile.gateway, and bot_bottle/backend/firecracker/infra_vm.py. All three had already been fixed independently on main (0d69667, 127ba49) — they were dropped when the branch was rebased. What remains is only the macOS-specific defect.

Closes #427. `bot_bottle/backend/macos_container/infra.py` spawned the gateway supervisor as `python3 /app/gateway_init.py`. `5ad3449` moved `bot_bottle` into a pip-installed package, so that file no longer exists — the supervisor never started, mitmdump never generated its CA, and `bot-bottle start` died downstream with `GatewayError: gateway CA not available`, which points at TLS rather than at the supervisor. Same defect `127ba49` fixed for firecracker. It survived on macOS because CI has no Apple Container runner (#426). `test_macos_infra` asserted the substring `"gateway_init.py"`, which the broken path satisfies, so it stayed green. Tightened to the module form, matching the assertion `127ba49` already made in `test_firecracker_infra_vm`. ## Verification Verified end to end on the macos-container backend: gateway image builds, CA is generated (fingerprint printed), agent registers, supervise MCP is wired, and a headless bottle runs a prompt to completion and exits 0. Full unit suite: 1879 passing. ## Note This branch originally also carried fixes for `pyproject.toml`, `Dockerfile.gateway`, and `bot_bottle/backend/firecracker/infra_vm.py`. All three had already been fixed independently on `main` (`0d69667`, `127ba49`) — they were dropped when the branch was rebased. What remains is only the macOS-specific defect.
didericis added 1 commit 2026-07-20 14:37:19 -04:00
fix(macos-container): launch gateway as a module, not /app/gateway_init.py
test / stage-firecracker-inputs (pull_request) Successful in 5s
Details
test / integration-docker (pull_request) Successful in 8s
Details
tracker-policy-pr / check-pr (pull_request) Successful in 7s
Details
test / unit (pull_request) Successful in 30s
Details
test / build-infra (pull_request) Successful in 3m56s
Details
test / integration-firecracker (pull_request) Successful in 1m36s
Details
test / coverage (pull_request) Successful in 2m33s
Details
test / publish-infra (pull_request) Has been skipped
Details
test / stage-firecracker-inputs (push) Successful in 2s
Details
test / integration-docker (push) Successful in 33s
Details
test / unit (push) Successful in 34s
Details
lint / lint (push) Successful in 48s
Details
Update Quality Badges / update-badges (push) Failing after 44s
Details
test / build-infra (push) Successful in 3m48s
Details
test / integration-firecracker (push) Successful in 1m44s
Details
test / coverage (push) Successful in 1m36s
Details
test / publish-infra (push) Successful in 2m33s
Details
44479f328e 
The macOS infra container's init script still spawned the supervisor as
`python3 /app/gateway_init.py`. 5ad3449 moved bot_bottle from flat files
under /app into a pip-installed package, so that file no longer exists:
the supervisor never started, mitmdump never generated its CA, and the
launch failed downstream with a misleading "gateway CA not available"
error pointing at TLS rather than at the supervisor.

This is the same defect 127ba49 fixed for the firecracker backend. It
survived on macOS because CI has no Apple Container runner — the KVM
runner added in c193b04 covers firecracker, and ubuntu-latest covers
docker, but nothing exercises macos_container.

test_macos_infra asserted the substring "gateway_init.py", which the
broken path satisfied; it now asserts the module form, matching the
assertion 127ba49 already made in test_firecracker_infra_vm.

Verified end to end on the macos-container backend: image builds, CA is
generated, agent registers, and a headless bottle runs a prompt.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
didericis force-pushed fix-gateway-package-paths from 83e8468927 to 44479f328e 2026-07-20 14:37:19 -04:00 Compare
didericis merged commit 44479f328e into main 2026-07-20 14:58:35 -04:00
didericis deleted branch fix-gateway-package-paths 2026-07-20 14:58:36 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status/Needs Triage
Awaiting initial classification
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#428
Delete Branch "fix-gateway-package-paths"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?