didericis/bot-bottle
1
0
Fork 0
Code Issues 34 Pull Requests 7 Actions Packages Releases Wiki Activity

fix(cli): exempt backend command from DB migration gate #420

Merged
didericis merged 1 commits from fix-backend-status-migration-gate into main 2026-07-18 16:33:07 -04:00
Conversation 1 Commits 1 Files Changed 2
+63 -1
didericis-claude commented 2026-07-18 15:27:51 -04:00
Collaborator
Copy Link
Copy Source

Problem

The Firecracker integration CI job fails at its Preflight — Firecracker host is ready step, which runs python3 cli.py backend status --backend=firecracker. On the self-hosted KVM / act runner stdin isn't a TTY, so the dispatcher's DB migration gate prompt (Migrate now? [y/N]) reads EOF and the command exits 1 before probing the host:

bot-bottle: database schema is out of date
Migrate now? [y/N] bot-bottle: error: migration required — re-run and confirm to migrate

Fix

backend setup/status/teardown manage host prerequisites (firecracker//dev/kvm/TAP pool) and never open the store, so gating them on the application DB schema is wrong regardless of CI. This exempts backend from the migration gate in bot_bottle/cli/__init__.py. Store-touching commands (start, list, resume, …) stay gated exactly as before.

Tests

Added a TestMigrationGate class in tests/unit/test_cli_dispatch.py:

  • a store command blocks when stdin can't confirm (the CI failure mode),
  • backend dispatches even on an unmigrated DB with EOF stdin,
  • a confirmed gate still migrates.

Reproduced the original failure and the fix locally; full CLI suite green.

Fixes #419

🤖 Generated with Claude Code

https://claude.ai/code/session_01S1qRZTJC6qgBsUSjNrBdkX

## Problem The Firecracker integration CI job fails at its `Preflight — Firecracker host is ready` step, which runs `python3 cli.py backend status --backend=firecracker`. On the self-hosted KVM / act runner stdin isn't a TTY, so the dispatcher's DB migration gate prompt (`Migrate now? [y/N]`) reads EOF and the command exits 1 before probing the host: ``` bot-bottle: database schema is out of date Migrate now? [y/N] bot-bottle: error: migration required — re-run and confirm to migrate ``` ## Fix `backend setup/status/teardown` manage host prerequisites (firecracker/`/dev/kvm`/TAP pool) and never open the store, so gating them on the application DB schema is wrong regardless of CI. This exempts `backend` from the migration gate in `bot_bottle/cli/__init__.py`. Store-touching commands (`start`, `list`, `resume`, …) stay gated exactly as before. ## Tests Added a `TestMigrationGate` class in `tests/unit/test_cli_dispatch.py`: - a store command blocks when stdin can't confirm (the CI failure mode), - `backend` dispatches even on an unmigrated DB with EOF stdin, - a confirmed gate still migrates. Reproduced the original failure and the fix locally; full CLI suite green. Fixes #419 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01S1qRZTJC6qgBsUSjNrBdkX
didericis-claude added 1 commit 2026-07-18 15:27:53 -04:00
fix(cli): exempt backend command from DB migration gate
test / integration (pull_request) Successful in 8s
Details
tracker-policy-pr / check-pr (pull_request) Successful in 9s
Details
test / unit (pull_request) Successful in 31s
Details
test / coverage (pull_request) Successful in 36s
Details
test / integration (push) Successful in 12s
Details
test / unit (push) Successful in 36s
Details
test / coverage (push) Successful in 39s
Details
Update Quality Badges / update-badges (push) Successful in 37s
Details
lint / lint (push) Successful in 2m38s
Details
015ff52eda 
`backend setup/status/teardown` manage host prerequisites only and never
open the store, but the CLI dispatcher ran the schema-migration gate before
every command. On a non-TTY runner the gate's `Migrate now? [y/N]` prompt
reads EOF and refuses, so `backend status --backend=firecracker` exits 1 —
breaking the Firecracker CI preflight on any host without a pre-migrated DB.

Exempt `backend` from the gate; store-touching commands stay gated.

Fixes #419

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S1qRZTJC6qgBsUSjNrBdkX
didericis approved these changes 2026-07-18 16:32:59 -04:00
didericis merged commit 015ff52eda into main 2026-07-18 16:33:07 -04:00
didericis deleted branch fix-backend-status-migration-gate 2026-07-18 16:33:10 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
didericis
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status/Needs Triage
Awaiting initial classification
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#420
Delete Branch "fix-backend-status-migration-gate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?