didericis/bot-bottle
1
0
Fork 0
Code Issues 25 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

feat(orchestrator): slice 13c(vi) — consolidated launch sequence (composition) #376

Closed
didericis-claude wants to merge 1 commits from orchestrator-consolidated-launch into orchestrator-gateway-provision
pull from: orchestrator-consolidated-launch
merge into: didericis:orchestrator-gateway-provision
Conversation 1 Commits 1 Files Changed 2
+236
didericis-claude commented 2026-07-13 22:03:22 -04:00
Collaborator
Copy Link
Copy Source

Sub-slice of slice 13c — the top-level composition that ties the primitives together.

launch_consolidated(egress_plan, git_gate_plan)

  1. ensure the orchestrator control plane + shared gateway are up (13a);
  2. read the gateway network's subnet + the gateway's own address, then allocate the bottle a pinned source IP (13c-ii), skipping the gateway + every live bottle;
  3. register it — egress policy blob + slug metadata (13b, 13c-iii) → bottle id + identity token;
  4. provision its git-gate repos/creds into the running gateway (13c-v).

Returns a LaunchContext (bottle_id, identity_token, source_ip, network, gateway_ip, orchestrator_url) — everything the agent container needs to attach. Rolls the registration back if provisioning fails, so a partial launch leaves no orphan.

teardown_consolidated(bottle_id) deregisters + deprovisions (idempotent).

The agent docker run itself stays the backend's job (provider provisioning) — this owns the orchestrator-facing wiring so the sequence is unit-testable: collaborators mocked, next_free_ip + registration_inputs run for real (IP allocation + the policy blob asserted end to end, including the rollback path).

Verification

pyright 0 errors, pylint 9.83/10 (new files 10.00), unit suite green (1755 tests; the 13 test_sidecar_init /bin/sleep errors are pre-existing NixOS-local noise).

Stacked on #375.

🤖 Generated with Claude Code

Sub-slice of **slice 13c** — the top-level composition that ties the primitives together. ### `launch_consolidated(egress_plan, git_gate_plan)` 1. ensure the orchestrator control plane + shared gateway are up (13a); 2. read the gateway network's subnet + the gateway's own address, then **allocate the bottle a pinned source IP** (13c-ii), skipping the gateway + every live bottle; 3. **register** it — egress policy blob + slug metadata (13b, 13c-iii) → bottle id + identity token; 4. **provision** its git-gate repos/creds into the running gateway (13c-v). Returns a `LaunchContext` (bottle_id, identity_token, source_ip, network, gateway_ip, orchestrator_url) — everything the agent container needs to attach. **Rolls the registration back** if provisioning fails, so a partial launch leaves no orphan. `teardown_consolidated(bottle_id)` deregisters + deprovisions (idempotent). The agent `docker run` itself stays the **backend's** job (provider provisioning) — this owns the orchestrator-facing wiring so the sequence is unit-testable: collaborators mocked, `next_free_ip` + `registration_inputs` run for real (IP allocation + the policy blob asserted end to end, including the rollback path). ### Verification pyright **0 errors**, pylint **9.83/10** (new files 10.00), unit suite green (1755 tests; the 13 `test_sidecar_init` `/bin/sleep` errors are pre-existing NixOS-local noise). Stacked on #375. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
didericis-claude added 1 commit 2026-07-13 22:03:23 -04:00
feat(orchestrator): slice 13c(vi) — consolidated launch sequence (composition)
test / unit (pull_request) Successful in 1m3s
Details
test / integration (pull_request) Successful in 21s
Details
test / coverage (pull_request) Successful in 1m12s
Details
lint / lint (push) Successful in 2m5s
Details
9896986810 
Composes the orchestrator primitives into the register/teardown sequence
that replaces the per-bottle bundle:

  launch_consolidated(egress_plan, git_gate_plan): ensure orchestrator +
    gateway up -> read the gateway network's subnet + the gateway's own
    address -> allocate the bottle a pinned source IP (skip the gateway +
    live bottles) -> register (egress policy blob + slug metadata) ->
    provision its git-gate repos/creds into the gateway. Returns a
    LaunchContext (bottle_id, identity_token, source_ip, network, gateway_ip,
    orchestrator_url) — everything the agent container needs to attach.
    Rolls the registration back if provisioning fails, so no orphan.

  teardown_consolidated(bottle_id): deregister + deprovision (idempotent).

The agent `docker run` itself stays the backend's job (provider
provisioning); this owns the orchestrator-facing wiring so the sequence is
unit-testable — collaborators mocked, next_free_ip + registration_inputs run
for real (IP allocation + policy blob asserted end to end).

pyright 0 errors; pylint 9.83/10; unit suite green (1755 tests; the 13
test_sidecar_init /bin/sleep errors are pre-existing NixOS-local noise).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WBMWTEtQdJ4W5UrWuLHCck
didericis-claude commented 2026-07-14 00:57:43 -04:00
Author
Collaborator
Copy Link
Copy Source

Collapsed into the single stack PR #380 (per-host orchestrator, PRD 0070). Closing this slice PR; review + merge happens on #380.

Collapsed into the single stack PR #380 (per-host orchestrator, PRD 0070). Closing this slice PR; review + merge happens on #380.
didericis-claude closed this pull request 2026-07-14 00:57:44 -04:00
Some checks are pending
test / unit (pull_request) Successful in 1m3s
Details
test / integration (pull_request) Successful in 21s
Details
test / coverage (pull_request) Successful in 1m12s
Details
lint / lint (push) Successful in 2m5s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#376
Delete Branch "orchestrator-consolidated-launch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?