didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Table-drive token-pattern detector tests #293

Open
didericis-claude wants to merge 1 commits from table-drive-dlp-tests into main
pull from: table-drive-dlp-tests
merge into: didericis:main
Conversation 0 Commits 1 Files Changed 1
+29 -92
didericis-claude commented 2026-06-25 19:41:31 -04:00
Collaborator
Copy Link
Copy Source

Closes #289.

Summary

The token-pattern detector had 15 near-identical test methods spread across TestScanTokenPatterns and TestScanTokenPatternsExtended — each scanned a body carrying one synthetic token and asserted the reason names the credential type.

This collapses them into a single _TOKEN_PATTERN_CASES table driven by unittest's subTest, so adding a new token shape is a one-line row and a failure reports the offending case id. Each case now also asserts block severity (previously only the AWS case did). TestScanTokenPatternsExtended is removed; its rows live in the table. The non-matrix cases (clean text, location, context, reason) stay as explicit methods.

No production code change. The file drops from 110 to 96 test methods with the same coverage; full unit suite passes; pyright clean; pylint 9.95.

Closes #289. ## Summary The token-pattern detector had 15 near-identical test methods spread across `TestScanTokenPatterns` and `TestScanTokenPatternsExtended` — each scanned a body carrying one synthetic token and asserted the reason names the credential type. This collapses them into a single `_TOKEN_PATTERN_CASES` table driven by `unittest`'s `subTest`, so adding a new token shape is a one-line row and a failure reports the offending case id. Each case now also asserts block severity (previously only the AWS case did). `TestScanTokenPatternsExtended` is removed; its rows live in the table. The non-matrix cases (clean text, location, context, reason) stay as explicit methods. No production code change. The file drops from 110 to 96 test methods with the same coverage; full unit suite passes; pyright clean; pylint 9.95.
didericis-claude added 1 commit 2026-06-25 19:41:32 -04:00
test(dlp): table-drive token-pattern detector cases
lint / lint (push) Successful in 1m51s
Details
test / unit (pull_request) Successful in 46s
Details
test / integration (pull_request) Successful in 18s
Details
c97c01d300 
The token-pattern detector had 15 near-identical test methods across
`TestScanTokenPatterns` and `TestScanTokenPatternsExtended`, each
scanning a body carrying one synthetic token and asserting the reason
names the credential type.

Collapse them into a single `_TOKEN_PATTERN_CASES` table driven by
`subTest`, so adding a new token shape is a one-line row. Each case now
also asserts block severity (previously only the AWS case did).
`TestScanTokenPatternsExtended` is removed; its rows live in the table.
The non-matrix cases (clean text, location, context, reason) stay as
explicit methods. No production code change.

Closes #289

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NkwFXLFff9PYPy4wgVBJp9
Some checks are pending
lint / lint (push) Successful in 1m51s
Details
test / unit (pull_request) Successful in 46s
Details
test / integration (pull_request) Successful in 18s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin table-drive-dlp-tests:table-drive-dlp-tests
git checkout table-drive-dlp-tests
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#293
Delete Branch "table-drive-dlp-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?