didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Fix unescaped quotes/newlines in YAML and gitconfig emitters #276

Merged
didericis merged 1 commits from fix/yaml-gitconfig-escape-special-chars into main 2026-06-25 04:32:25 -04:00
Conversation 0 Commits 1 Files Changed 4
+141 -10
didericis-claude commented 2026-06-25 03:43:02 -04:00
Collaborator
Copy Link
Copy Source

Closes #258.

Summary

  • egress.py: Added _yaml_str_escape helper and applied it to every manifest string interpolated into a double-quoted YAML scalar in egress_render_routes and _render_match_entry (host, auth_scheme, token_env, path values, header names/values, method names). A stray " no longer corrupts routes.yaml; a newline no longer splits a scalar across lines.
  • git_gate.py: Added _gitconfig_validate_value and called it on each Upstream value (and the derived host alias) before writing the insteadOf line. A newline in Upstream is rejected with a clear error rather than silently injecting arbitrary gitconfig keys.
  • Both fixes are covered by new unit tests in test_egress.py and test_provision_git.py.
Closes #258. ## Summary - **`egress.py`**: Added `_yaml_str_escape` helper and applied it to every manifest string interpolated into a double-quoted YAML scalar in `egress_render_routes` and `_render_match_entry` (host, auth_scheme, token_env, path values, header names/values, method names). A stray `"` no longer corrupts `routes.yaml`; a newline no longer splits a scalar across lines. - **`git_gate.py`**: Added `_gitconfig_validate_value` and called it on each `Upstream` value (and the derived host alias) before writing the `insteadOf` line. A newline in `Upstream` is rejected with a clear error rather than silently injecting arbitrary gitconfig keys. - Both fixes are covered by new unit tests in `test_egress.py` and `test_provision_git.py`.
didericis added 1 commit 2026-06-25 04:23:20 -04:00
fix: escape quotes/newlines in YAML and gitconfig emitters
test / unit (pull_request) Successful in 35s
Details
test / integration (pull_request) Successful in 17s
Details
lint / lint (push) Successful in 1m48s
Details
test / unit (push) Successful in 32s
Details
test / integration (push) Successful in 16s
Details
Update Quality Badges / update-badges (push) Successful in 1m18s
Details
515a95a79d 
Closes #258.

`egress_render_routes` and `_render_match_entry` now pass all manifest
strings (host, auth_scheme, token_env, path/header values) through
`_yaml_str_escape` before interpolating into double-quoted YAML scalars,
preventing stray `"` or newlines from corrupting routes.yaml.

`git_gate_render_gitconfig` now calls `_gitconfig_validate_value` on
each Upstream value (and the derived alias) before writing the
`insteadOf` line, rejecting any value containing a newline that would
inject arbitrary gitconfig keys.
didericis force-pushed fix/yaml-gitconfig-escape-special-chars from 43e8c5244c to 515a95a79d 2026-06-25 04:23:20 -04:00 Compare
didericis merged commit 515a95a79d into main 2026-06-25 04:32:25 -04:00
didericis deleted branch fix/yaml-gitconfig-escape-special-chars 2026-06-25 04:32:25 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#276
Delete Branch "fix/yaml-gitconfig-escape-special-chars"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?