didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

feat(provider): support startup args settings #265

Merged
didericis merged 1 commits from feat/provider-startup-args into main 2026-06-24 22:58:34 -04:00
Conversation 1 Commits 1 Files Changed 7
+122 -9
didericis-codex commented 2026-06-24 22:53:06 -04:00
Collaborator
Copy Link
Copy Source

Adds provider-level startup_args passthrough for built-in agent providers.

Changes:

  • validate agent_provider.settings.startup_args as string args
  • pass startup args through Claude and Codex provider plans
  • append extra startup args for Pi after generated --models args
  • cover manifest validation and provider plan behavior in unit tests

Verification:

  • python3 -m unittest tests.unit.test_manifest_egress tests.unit.test_agent_provider tests.unit.test_cli_start_settle
  • python3 -m py_compile bot_bottle/agent_provider.py bot_bottle/manifest_agent.py bot_bottle/contrib/claude/agent_provider.py bot_bottle/contrib/codex/agent_provider.py bot_bottle/contrib/pi/agent_provider.py
  • venv/bin/pyright
Adds provider-level startup_args passthrough for built-in agent providers. Changes: - validate agent_provider.settings.startup_args as string args - pass startup args through Claude and Codex provider plans - append extra startup args for Pi after generated --models args - cover manifest validation and provider plan behavior in unit tests Verification: - python3 -m unittest tests.unit.test_manifest_egress tests.unit.test_agent_provider tests.unit.test_cli_start_settle - python3 -m py_compile bot_bottle/agent_provider.py bot_bottle/manifest_agent.py bot_bottle/contrib/claude/agent_provider.py bot_bottle/contrib/codex/agent_provider.py bot_bottle/contrib/pi/agent_provider.py - venv/bin/pyright
didericis-codex added 1 commit 2026-06-24 22:53:09 -04:00
feat(provider): support startup args settings
test / unit (pull_request) Successful in 41s
Details
test / integration (pull_request) Successful in 26s
Details
lint / lint (push) Successful in 2m12s
Details
test / unit (push) Successful in 41s
Details
test / integration (push) Successful in 26s
Details
Update Quality Badges / update-badges (push) Successful in 2m9s
Details
ecaae708f7
didericis approved these changes 2026-06-24 22:58:26 -04:00
didericis merged commit ecaae708f7 into main 2026-06-24 22:58:34 -04:00
didericis deleted branch feat/provider-startup-args 2026-06-24 22:58:35 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
didericis
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#265
Delete Branch "feat/provider-startup-args"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?