Default the supervise flag to true #250
Reference in New Issue
Block a user
Delete Branch "remove-supervise-flag"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #249.
Summary
Bottles should be supervised by default. Instead of removing the
superviseflag (which would make supervision mandatory), this keeps the flag and flips its default fromfalsetotrue.supervise:now bring up the stuck-recovery sidecar automatically.supervise: falseremains a supported opt-out for headless/CI/ephemeral bottles that don't have an operator watching the proposal queue.Why not remove the flag entirely
The earlier version of this PR removed the flag and made supervision unconditional. That was reconsidered: the current supervise sidecar is agent-initiated (the agent proposes
egress-block/capability-block; an operator approves), so it can't enforce anything against an uncooperative agent. Making it mandatory would not deliver forced cost-cutoff and would remove a legitimate unsupervised mode. The enforcement/observability plane that should be unconditional is tracked separately in #251.Scope
One-line behavior change in
ManifestBottle(dataclass default +from_dictdefault + docstrings). All other plumbing (SupervisePlan | None, per-backend conditional rendering) is unchanged. Full unit suite passes (1072 tests).bdca1c8beato369d332204Remove the supervise flagto Default the supervise flag to trueNote: the branch is still named
remove-supervise-flagfrom the original approach. The PR no longer removes the flag — it just flips the default totrueand keepssupervise: falseas an opt-out. Leaving the branch name as-is rather than repointing the PR.