didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Use label as container slug prefix when provided #242

Merged
didericis merged 3 commits from use-label-as-container-slug into main 2026-06-22 15:36:55 -04:00
Conversation 1 Commits 3 Files Changed 5
+137 -10
didericis-claude commented 2026-06-22 15:17:08 -04:00
Collaborator
Copy Link
Copy Source

Summary

  • mint_slug in resolve_common.py now uses spec.label as the slug prefix when the user has named the bottle via the TUI label field, falling back to spec.agent_name when no label is given.
  • spec.identity (the resume path) still takes precedence over both.
  • Four new unit tests in TestMintSlug cover the no-label fallback, label-as-prefix, label-slugification, and identity-precedence cases.
## Summary - `mint_slug` in `resolve_common.py` now uses `spec.label` as the slug prefix when the user has named the bottle via the TUI label field, falling back to `spec.agent_name` when no label is given. - `spec.identity` (the resume path) still takes precedence over both. - Four new unit tests in `TestMintSlug` cover the no-label fallback, label-as-prefix, label-slugification, and identity-precedence cases.
didericis-claude added 1 commit 2026-06-22 15:17:10 -04:00
feat: use label as container slug prefix when provided
lint / lint (push) Successful in 1m45s
Details
test / unit (pull_request) Successful in 33s
Details
test / integration (pull_request) Successful in 19s
Details
e463670649 
When a user names a bottle via the TUI label field, that name is now
used as the slug prefix for the container identity instead of always
falling back to the agent name.
didericis commented 2026-06-22 15:22:05 -04:00
Owner
Copy Link
Copy Source

Not quite what I wanted: the slug should use the label when provided. This may introduce name conflicts/collisions, but this is ok: we don't want users to use the same name for multiple agents.

We should check that the name is valid when assigning a label, and if an agent with that name and agent is already running, the cli prompt where we ask for the label again with a disclaimer that says " already in use"

Not quite what I wanted: the *slug* should use the label when provided. This may introduce name conflicts/collisions, but this is ok: we don't want users to use the same name for multiple agents. We should check that the name is valid when assigning a label, and if an agent with that name and agent is already running, the cli prompt where we ask for the label again with a disclaimer that says "<x> already in use"
didericis added 1 commit 2026-06-22 15:26:44 -04:00
fix: label becomes the full slug; re-prompt on collision
lint / lint (push) Failing after 1m44s
Details
test / unit (pull_request) Successful in 33s
Details
test / integration (pull_request) Successful in 17s
Details
54760964cf 
When a label is given it is now used verbatim as the slug (no random
suffix), so two launches with the same label collide by design.  The
CLI re-prompts via the TUI name modal with a disclaimer when the
candidate slug is already in use among running bottles.
didericis added 1 commit 2026-06-22 15:30:57 -04:00
fix: add type annotations to _modal stub for pyright
test / unit (pull_request) Successful in 34s
Details
test / integration (pull_request) Successful in 19s
Details
lint / lint (push) Successful in 1m36s
Details
test / unit (push) Successful in 30s
Details
test / integration (push) Successful in 18s
Details
Update Quality Badges / update-badges (push) Successful in 1m19s
Details
1a5b6e25f8
didericis merged commit 1a5b6e25f8 into main 2026-06-22 15:36:55 -04:00
didericis deleted branch use-label-as-container-slug 2026-06-22 15:36:56 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#242
Delete Branch "use-label-as-container-slug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?