didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

test(git-gate): shell-escaping regression tests (issue #159) #168

Merged
didericis merged 1 commits from regression/issue-159-shell-escaping into main 2026-06-03 11:00:57 -04:00
Conversation 1 Commits 1 Files Changed 1
+98
didericis-claude commented 2026-06-03 10:57:32 -04:00
Collaborator
Copy Link
Copy Source

Closes #159.

Related file: ca6d257f30/tests/unit/test_git_gate.py

Summary

  • Adds TestShellEscaping class to tests/unit/test_git_gate.py with 6 new test methods
  • Covers all six pathological character classes (single-quote, double-quote, space, semicolon, newline, backtick) in both upstream URL and name positions
  • Validates each rendered output via sh -n to confirm syntactic correctness
  • Asserts original values are preserved verbatim via shlex.quote encoding
  • Adds sh -n smoke tests for the static pre-receive and access-hook scripts

Changes (1 commit)

  • ca6d257 test(git-gate): add shell-escaping regression tests (issue #159)
Closes #159. Related file: https://gitea.dideric.is/didericis/bot-bottle/src/commit/ca6d257f30c1102df6bff7d6370d0cc2ec9bd1a0/tests/unit/test_git_gate.py ## Summary - Adds `TestShellEscaping` class to `tests/unit/test_git_gate.py` with 6 new test methods - Covers all six pathological character classes (single-quote, double-quote, space, semicolon, newline, backtick) in both upstream URL and name positions - Validates each rendered output via `sh -n` to confirm syntactic correctness - Asserts original values are preserved verbatim via `shlex.quote` encoding - Adds `sh -n` smoke tests for the static pre-receive and access-hook scripts ## Changes (1 commit) - `ca6d257` test(git-gate): add shell-escaping regression tests (issue #159)
didericis-claude added 1 commit 2026-06-03 10:57:34 -04:00
test(git-gate): add shell-escaping regression tests (issue #159)
test / unit (pull_request) Successful in 36s
Details
test / integration (pull_request) Successful in 44s
Details
test / unit (push) Successful in 35s
Details
test / integration (push) Successful in 42s
Details
ca6d257f30 
Cover all six pathological character classes (single-quote,
double-quote, space, semicolon, newline, backtick) in both
upstream URL and name positions.  Each case validates rendered
output via `sh -n` and asserts the original value is preserved
verbatim after shlex.quote encoding.  Also add `sh -n` smoke
tests for the static pre-receive and access-hook scripts.
didericis approved these changes 2026-06-03 11:00:51 -04:00
didericis merged commit ca6d257f30 into main 2026-06-03 11:00:57 -04:00
didericis deleted branch regression/issue-159-shell-escaping 2026-06-03 11:00:57 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
didericis
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#168
Delete Branch "regression/issue-159-shell-escaping"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?