didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

PRD 0044: print parity across backends #147

Merged
didericis merged 4 commits from prd-0044-print-parity-across-backends into main 2026-06-02 12:15:25 -04:00
Conversation 2 Commits 4 Files Changed 5
+424 -125
didericis-claude commented 2026-06-02 11:51:05 -04:00
Collaborator
Copy Link
Copy Source

Closes #96.

PRD: c1a4fa756a/docs/prds/0044-print-parity-across-backends.md

Summary

  • Hoist git_gate_plan, egress_plan, agent_provision, and supervise_plan from the concrete BottlePlan subclasses to BottlePlan
  • Replace @abstractmethod print with a single concrete implementation on BottlePlan
  • Unify git gate rendering to name → upstream_host:upstream_port (from resolved plan, not manifest)
  • Unify egress rendering to include [auth:scheme] on both backends

Changes (1 commit)

  • docs/prds/0044-print-parity-across-backends.md — add PRD 0044 (Draft)
Closes #96. PRD: https://gitea.dideric.is/didericis/bot-bottle/src/commit/c1a4fa756a2f44289d53b1430f2debbb6bf3e7bb/docs/prds/0044-print-parity-across-backends.md ## Summary - Hoist `git_gate_plan`, `egress_plan`, `agent_provision`, and `supervise_plan` from the concrete `BottlePlan` subclasses to `BottlePlan` - Replace `@abstractmethod print` with a single concrete implementation on `BottlePlan` - Unify git gate rendering to `name → upstream_host:upstream_port` (from resolved plan, not manifest) - Unify egress rendering to include `[auth:scheme]` on both backends ## Changes (1 commit) - `docs/prds/0044-print-parity-across-backends.md` — add PRD 0044 (Draft)
didericis force-pushed prd-0044-print-parity-across-backends from c1a4fa756a to 46c74422c5 2026-06-02 11:55:42 -04:00 Compare
didericis added 4 commits 2026-06-02 12:12:13 -04:00
docs(prd): add PRD 0044 — print parity across backends 71ac555f25
refactor: hoist plan fields and print to BottlePlan base class (PRD 0044) 53219a55e1 
Move git_gate_plan, egress_plan, supervise_plan, and agent_provision
from DockerBottlePlan and SmolmachinesBottlePlan into BottlePlan.
Replace the abstract print method with a single concrete implementation
that renders git gate entries as "name → upstream_host:upstream_port"
and egress routes with conditional "[auth:scheme]" annotations.
test: add cross-backend print parity tests (PRD 0044) a0762ac2d3 
Shared fixtures build DockerBottlePlan and SmolmachinesBottlePlan from
identical git_gate_plan and egress_plan inputs and assert that both
backends render the same git gate lines (name → host:port) and egress
lines (host [auth:scheme] when authenticated, host alone otherwise).
docs: mark PRD 0044 Active
test / unit (pull_request) Successful in 34s
Details
test / integration (pull_request) Successful in 41s
Details
test / unit (push) Successful in 34s
Details
test / integration (push) Successful in 43s
Details
fcd1b34e49
didericis force-pushed prd-0044-print-parity-across-backends from d3c04c4b36 to fcd1b34e49 2026-06-02 12:12:13 -04:00 Compare
didericis reviewed 2026-06-02 12:14:09 -04:00
bot_bottle/backend/__init__.py
@@ -73,0 +78,4 @@
git_gate_plan: GitGatePlan
egress_plan: EgressPlan
supervise_plan: SupervisePlan | None
agent_provision: AgentProvisionPlan
didericis commented 2026-06-02 12:14:09 -04:00
Owner
Copy Link
Copy Source

nit, name should also end in plan (agent_provision_plan)

nit, name should also end in `plan` (`agent_provision_plan`)
didericis approved these changes 2026-06-02 12:15:13 -04:00
didericis merged commit fcd1b34e49 into main 2026-06-02 12:15:25 -04:00
didericis deleted branch prd-0044-print-parity-across-backends 2026-06-02 12:15:26 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
didericis
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#147
Delete Branch "prd-0044-print-parity-across-backends"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?