didericis/bot-bottle
1
0
Fork 0
Code Issues 33 Pull Requests 9 Actions Packages Releases Wiki Activity

refactor: quality cleanup - orchestrator FastAPI transport (chunk 2/11) #518

Closed
didericis-codex wants to merge 4 commits from refactor/orchestrator-fastapi into chore/misc-quality-cleanup
pull from: refactor/orchestrator-fastapi
merge into: didericis:chore/misc-quality-cleanup
Conversation 0 Commits 4 Files Changed 17
+766 -508
didericis-codex commented 2026-07-26 19:44:47 -04:00
Collaborator
Copy Link
Copy Source

Stacked on #514. Second quality-cleanup PR tracked by #444.

Replaces the orchestrator HTTP transport and its oversized manual dispatcher:

  • Explicit FastAPI endpoints: typed route functions replace the 244-line conditional dispatcher and repeated JSON parsing/validation branches.
  • Bounded Uvicorn transport: concurrency is capped and request reads use Uvicorn flow control.
  • Pre-body security boundary: outer ASGI middleware authenticates callers, caps declared and streamed bodies at 1 MiB, and applies a total body-read deadline.
  • Deterministic resource errors: oversized streamed bodies return 413 and slow request bodies return 408 before reaching route handlers.
  • Error containment: internal failures return redacted JSON while logs retain method, route, and exception type without request secrets.
  • Image-only dependencies: FastAPI/Uvicorn are exact-versioned and hash-locked in orchestrator images; a dependency-free HTTP contract keeps host CLI/backend imports clean.
  • Direct ASGI tests: route tests exercise the real application through an ASGI transport; the temporary production dispatch() compatibility adapter is removed.

Still to come in this stack

  • #523 — extract the egress Git, route, authorization, and DLP policy pipeline from the mitmproxy lifecycle adapter.
  • #524 — separate supervisor MCP transport from tool dispatch and proposal formatting.

Remaining stack

  • #525 — authoritative backend cleanup and destructive revalidation.
  • #526 — bounded gateway HTTP work and strict policy introspection.
  • #527 — gateway shutdown diagnostics.

Final stack extension

  • #528 — authoritative resource identities and bounded artifact transfers.

Validation: The complete eleven-PR stack passes all 2,520 unit tests; full-repository Pyright reports 0 errors; git diff --check passes.

Refs #444.

Final stack extension

  • #530 — cleanup execution and mandatory authenticated-secret integrity.

Final stack extension

  • #531 — bounded heavy Git and cleanup operations.

Final stack extension

  • #532 — fail-closed shared database and gateway credential permissions.
Stacked on #514. Second quality-cleanup PR tracked by #444. Replaces the orchestrator HTTP transport and its oversized manual dispatcher: - **Explicit FastAPI endpoints:** typed route functions replace the 244-line conditional dispatcher and repeated JSON parsing/validation branches. - **Bounded Uvicorn transport:** concurrency is capped and request reads use Uvicorn flow control. - **Pre-body security boundary:** outer ASGI middleware authenticates callers, caps declared and streamed bodies at 1 MiB, and applies a total body-read deadline. - **Deterministic resource errors:** oversized streamed bodies return 413 and slow request bodies return 408 before reaching route handlers. - **Error containment:** internal failures return redacted JSON while logs retain method, route, and exception type without request secrets. - **Image-only dependencies:** FastAPI/Uvicorn are exact-versioned and hash-locked in orchestrator images; a dependency-free HTTP contract keeps host CLI/backend imports clean. - **Direct ASGI tests:** route tests exercise the real application through an ASGI transport; the temporary production `dispatch()` compatibility adapter is removed. **Still to come in this stack** - #523 — extract the egress Git, route, authorization, and DLP policy pipeline from the mitmproxy lifecycle adapter. - #524 — separate supervisor MCP transport from tool dispatch and proposal formatting. **Remaining stack** - #525 — authoritative backend cleanup and destructive revalidation. - #526 — bounded gateway HTTP work and strict policy introspection. - #527 — gateway shutdown diagnostics. **Final stack extension** - #528 — authoritative resource identities and bounded artifact transfers. **Validation:** The complete eleven-PR stack passes all 2,520 unit tests; full-repository Pyright reports 0 errors; `git diff --check` passes. Refs #444. **Final stack extension** - #530 — cleanup execution and mandatory authenticated-secret integrity. **Final stack extension** - #531 — bounded heavy Git and cleanup operations. **Final stack extension** - #532 — fail-closed shared database and gateway credential permissions.
didericis-codex changed title from refactor(orchestrator): replace manual HTTP dispatch with FastAPI to refactor(orchestrator): migrate control plane to FastAPI and Uvicorn 2026-07-26 19:47:00 -04:00
didericis added the Kind/Enhancement label 2026-07-26 19:47:59 -04:00
didericis-codex changed title from refactor(orchestrator): migrate control plane to FastAPI and Uvicorn to quality cleanup: orchestrator FastAPI transport (chunk 1/3) 2026-07-26 22:16:59 -04:00
didericis-codex changed title from quality cleanup: orchestrator FastAPI transport (chunk 1/3) to refactor: quality cleanup - orchestrator FastAPI transport (chunk 1/3) 2026-07-26 22:17:16 -04:00
didericis force-pushed refactor/orchestrator-fastapi from cf7482b098 to bc716bb5a3 2026-07-26 22:19:39 -04:00 Compare
didericis force-pushed refactor/orchestrator-fastapi from b2965e292f to 2234145ab4 2026-07-26 22:58:25 -04:00 Compare
didericis-codex changed title from refactor: quality cleanup - orchestrator FastAPI transport (chunk 1/3) to refactor: quality cleanup - orchestrator FastAPI transport (chunk 2/7) 2026-07-26 23:17:11 -04:00
didericis force-pushed refactor/orchestrator-fastapi from 2234145ab4 to a1acdd9665 2026-07-26 23:39:56 -04:00 Compare
didericis-codex changed title from refactor: quality cleanup - orchestrator FastAPI transport (chunk 2/7) to refactor: quality cleanup - orchestrator FastAPI transport (chunk 2/8) 2026-07-26 23:40:59 -04:00
didericis force-pushed refactor/orchestrator-fastapi from a1acdd9665 to c472deafaf 2026-07-26 23:56:02 -04:00 Compare
didericis-codex changed title from refactor: quality cleanup - orchestrator FastAPI transport (chunk 2/8) to refactor: quality cleanup - orchestrator FastAPI transport (chunk 2/9) 2026-07-27 00:02:29 -04:00
didericis force-pushed refactor/orchestrator-fastapi from c472deafaf to ca1bcf0ceb 2026-07-27 00:17:47 -04:00 Compare
didericis-codex changed title from refactor: quality cleanup - orchestrator FastAPI transport (chunk 2/9) to refactor: quality cleanup - orchestrator FastAPI transport (chunk 2/10) 2026-07-27 00:25:53 -04:00
didericis added 4 commits 2026-07-27 00:46:16 -04:00
build(orchestrator): pin FastAPI runtime dependencies a25ea7c188
refactor(orchestrator): replace manual HTTP dispatch with FastAPI 31a7efc0ed
fix(orchestrator): keep host client dependency-free 7dcce2ff12
fix(orchestrator): bound streamed request bodies
test / integration-docker (pull_request) Has been cancelled
Details
test / image-input-builds (pull_request) Successful in 42s
Details
test / unit (pull_request) Failing after 14m6s
Details
test / coverage (pull_request) Has been skipped
Details
tracker-policy-pr / check-pr (pull_request) Failing after 13s
Details
ffda40abae
didericis force-pushed refactor/orchestrator-fastapi from ca1bcf0ceb to ffda40abae 2026-07-27 00:46:16 -04:00 Compare
didericis-codex changed title from refactor: quality cleanup - orchestrator FastAPI transport (chunk 2/10) to refactor: quality cleanup - orchestrator FastAPI transport (chunk 2/11) 2026-07-27 00:48:12 -04:00
didericis-codex closed this pull request 2026-07-27 01:35:11 -04:00
Some checks are pending
test / integration-docker (pull_request) Has been cancelled
Details
test / image-input-builds (pull_request) Successful in 42s
Details
test / unit (pull_request) Failing after 14m6s
Details
test / coverage (pull_request) Has been skipped
Details
tracker-policy-pr / check-pr (pull_request) Failing after 13s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status/Needs Triage
Awaiting initial classification
No Label Kind/Enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#518
Delete Branch "refactor/orchestrator-fastapi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?