feat(orchestrator): slice 5 — build the consolidated sidecar bundle image #360
Open
didericis-claude
wants to merge 1 commits from
orchestrator-slice5 into orchestrator-slice4
pull from: orchestrator-slice5
merge into: didericis:orchestrator-slice4
didericis:main
didericis:orchestrator-registration
didericis:orchestrator-lifecycle
didericis:orchestrator-supervise-writers
didericis:orchestrator-supervise-multitenant
didericis:orchestrator-gitgate-multitenant
didericis:orchestrator-rename-gateway
didericis:orchestrator-slice8
didericis:orchestrator-slice7
didericis:orchestrator-slice6
didericis:prd-orchestrator
didericis:orchestrator-slice4
didericis:orchestrator-slice3
didericis:orchestrator-slice2
didericis:ci-kvm-runner
didericis:post-build-image-smoke-test
didericis:firecracker-backend
didericis:issue-330-cached-images
didericis:forge-native-integration
didericis:prd-smolmachines-linux
didericis:claude-forward-host-credentials
didericis:fold-orchestrator-subpackage
didericis:prd-egress-control-plane
didericis:manifest-break-import-cycle
didericis:dlp-supervise-quality-fixes
didericis:table-drive-dlp-tests
didericis:fix-integration-test-failures
didericis:fix/macos-container-relative-dockerfile
didericis:prd-0054-install-script
didericis:commit-bottle-state
didericis:pr-211
didericis:move-codex-auth-to-contrib
didericis:feat/pipelock-skip-scan-extensions
didericis:prd-0049-named-labelled-agents
didericis:harden-git-gate-shell-rendering
Labels
Clear labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: didericis/bot-bottle#360
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "orchestrator-slice5"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Slice 5 of PRD 0070, stacked on #358. Answers "where do we build the consolidated sidecar" — nowhere, until now (slice 4 launched a bare placeholder image).
sidecar.py—Sidecar.ensure_built()(default no-op) +DockerSidecarnow defaults its image to the real bundle (bot-bottle-sidecars) andensure_built()builds it fromDockerfile.sidecarswhendocker image inspectshows it's missing (no-op when present, or when no dockerfile is configured — e.g. a pre-pulled image). Addsimage_exists().service.py—ensure_sidecar()now builds then runs.__main__.py—--sidecarruns the consolidated bundle (build-if-missing).Scope note (honest): this builds + launches the bundle container. Making the running instance functional across bottles still needs the per-bottle source-IP-keyed multi-tenant config + registration/reload, and routing agent bottles to it — the next slices (now in PRD 0070's roadmap). The bundle's per-bottle CA/routes/keys config is why a single shared instance isn't functional yet.
Tests: unit (docker mocked) — image_exists, ensure_built builds-when-missing / no-op-when-present / no-op-without-dockerfile / raises-on-failure; ensure_sidecar builds-then-runs; integration (gated, deliberately no heavy image build) — image_exists reflects real docker state. Full suite green (only pre-existing
/bin/sleeperrors).Merge order: #352 → #356 → #357 → #358 → this.
🤖 Generated with Claude Code
Answers "where do we build the consolidated sidecar": nowhere, until now. * sidecar.py — `Sidecar.ensure_built()` (default no-op) + `DockerSidecar` now defaults its image to the real bundle (`bot-bottle-sidecars`) and `ensure_built()` builds it from `Dockerfile.sidecars` when `docker image inspect` shows it's missing (no-op when present or when no dockerfile is configured, e.g. a pre-pulled image). `image_exists()` added. * service.py — `ensure_sidecar()` now builds then runs. * __main__.py — `--sidecar` runs the consolidated bundle (build-if-missing). Scope note: this builds + launches the bundle *container*; making the running instance functional across bottles needs the per-bottle, source-IP-keyed multi-tenant config + registration/reload, and routing agent bottles to it — the next slices (added to PRD 0070's roadmap). Tests: unit (docker mocked) — image_exists, ensure_built builds when missing / no-op when present / no-op without a dockerfile / raises on build failure; ensure_sidecar builds-then-runs; integration (gated, no heavy build) — image_exists reflects real docker state. Full suite green (only pre-existing /bin/sleep errors). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBMWTEtQdJ4W5UrWuLHCckView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.