feat(orchestrator): slice 3 — real Docker launch broker #357
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: didericis/bot-bottle#357
Reference in New Issue
Block a user
Delete Branch "orchestrator-slice3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Slice 3 of PRD 0070, stacked on #356 (branched off
orchestrator-slice2). The first concreteLaunchBroker, proving the orchestrator → backend seam on the cheapest backend.docker_broker.py—DockerBrokerruns a container on a verified launch (docker run --detach --name <bottle> --label ... <image_ref>) and removes it on teardown (docker rm --force, idempotent on an already-absent container). The argv is built only from the request's static ids/flags, so nothing free-form reachesdocker; provenance + schema verification are inherited fromLaunchBroker.submit.__main__.pygains--broker {stub,docker}so the harness can drive real containers.Scope: launches a single container from
image_ref— that's the seam. The full agent + sidecar bundle (networks, mounts, the consolidated sidecar) is a later slice.Tests: unit (docker mocked) — argv from static fields only, launch/teardown call the right commands, missing-image + docker-failure raise, teardown idempotent on missing, forged token never touches docker; integration (gated on a reachable daemon via
skip_unless_docker) — launch creates a real container, teardown removes it. Full suite green (only pre-existing/bin/sleeperrors); integration verified locally against real docker.Merge order: #352 → #356 → this.
🤖 Generated with Claude Code
The first concrete LaunchBroker, proving the orchestrator -> backend seam on the cheapest backend (the sidecar bundle is already containers): * orchestrator/docker_broker.py — DockerBroker runs a container on a verified launch (`docker run --detach --name <bottle> --label ... <image_ref>`) and removes it on teardown (`docker rm --force`, idempotent on an already-absent container). The argv is built only from the request's static ids/flags, so nothing free-form reaches docker; provenance/schema verification is inherited from LaunchBroker.submit. * __main__.py gains `--broker {stub,docker}` so the harness can drive real containers. Slice 3 launches a single container from image_ref (the seam); the full agent + sidecar bundle is a later slice. Tests: unit (docker mocked) — argv from static fields, launch/teardown call the right commands, missing-image and docker-failure raise, teardown idempotent on missing, forged token never touches docker; integration (gated on a reachable daemon) — launch creates a real container, teardown removes it. Full suite green (only pre-existing /bin/sleep errors); integration verified locally against real docker. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBMWTEtQdJ4W5UrWuLHCck@didericis-claude Looks good. Move onto the next slice.
✅ CI fully green on
44e611d— lint (pylint 9.83/10 + pyright-strict), unit, integration, coverage all pass.The earlier red was a single pyright-strict error: the integration-test helper used
**kw: str, which let astrreachLaunchRequest.slot: int | None. Fixed by passing explicitLaunchRequests (44e611d). pylint was already passing — the items it lists are all pre-existing warnings in other files, well above the 8.0 gate.Slice 3 is ready for review. Stack merge order: #352 → #356 → #357.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.