didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Ratchet supervise coverage to >=90% (ADR 0004) #300

Open
didericis-claude wants to merge 1 commits from ratchet-supervise-90 into ratchet-manifest-90
pull from: ratchet-supervise-90
merge into: didericis:ratchet-manifest-90
Conversation 0 Commits 1 Files Changed 1
+132
didericis-claude commented 2026-06-25 22:19:39 -04:00
Collaborator
Copy Link
Copy Source

Stacked on #299 (base = ratchet-manifest-90). Sixth per-module ratchet under ADR 0004.

Summary

Covers the supervise queue/audit error + fallback branches:

  • path helpers (bot_bottle_root, queue_dir_for_slug, _id_from_proposal_filename non-match)
  • read_proposal / read_response reject non-object JSON
  • list_pending_proposals skips unreadable / non-dict / incomplete proposals and ones with a response already present
  • wait_for_response tolerates a malformed or incomplete response file and times out at the deadline
  • read_audit_entries returns [] for a missing log and skips blank / non-JSON / non-dict / missing-field lines
  • the fcntl flock helpers swallow OSError on a bad fd

Coverage

Module Before After
supervise.py 89% 99%

The one remaining line is an unreachable continue (the glob already guarantees the .proposal.json suffix). 12 new tests; full suite (1490) passes; pyright clean; pylint 9.62.

Stacked on #299 (base = `ratchet-manifest-90`). Sixth per-module ratchet under ADR 0004. ## Summary Covers the supervise queue/audit error + fallback branches: - path helpers (`bot_bottle_root`, `queue_dir_for_slug`, `_id_from_proposal_filename` non-match) - `read_proposal` / `read_response` reject non-object JSON - `list_pending_proposals` skips unreadable / non-dict / incomplete proposals and ones with a response already present - `wait_for_response` tolerates a malformed or incomplete response file and times out at the deadline - `read_audit_entries` returns `[]` for a missing log and skips blank / non-JSON / non-dict / missing-field lines - the `fcntl` flock helpers swallow `OSError` on a bad fd ## Coverage | Module | Before | After | |---|---|---| | `supervise.py` | 89% | **99%** | The one remaining line is an unreachable `continue` (the glob already guarantees the `.proposal.json` suffix). 12 new tests; full suite (1490) passes; pyright clean; pylint 9.62.
didericis-claude added 1 commit 2026-06-25 22:19:41 -04:00
test(supervise): ratchet supervise coverage to >=90%
test / unit (pull_request) Successful in 46s
Details
test / integration (pull_request) Successful in 17s
Details
test / coverage (pull_request) Successful in 58s
Details
lint / lint (push) Successful in 1m54s
Details
8caa79ee76 
Sixth per-module ratchet under ADR 0004. Cover the queue/audit
malformed-input and fallback branches:

- path helpers (bot_bottle_root, queue_dir_for_slug,
  _id_from_proposal_filename non-match)
- read_proposal / read_response reject non-object JSON
- list_pending_proposals skips unreadable/non-dict/incomplete
  proposals and ones with a response already present
- wait_for_response tolerates a malformed or incomplete response file
  and then times out at the deadline
- read_audit_entries returns [] for a missing log and skips blank /
  non-JSON / non-dict / missing-field lines
- the fcntl flock helpers swallow OSError on a bad fd

supervise.py: 89% -> 99%. The one remaining line is an unreachable
`continue` (glob already guarantees the .proposal.json suffix).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NkwFXLFff9PYPy4wgVBJp9
Some checks are pending
test / unit (pull_request) Successful in 46s
Details
test / integration (pull_request) Successful in 17s
Details
test / coverage (pull_request) Successful in 58s
Details
lint / lint (push) Successful in 1m54s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin ratchet-supervise-90:ratchet-supervise-90
git checkout ratchet-supervise-90
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#300
Delete Branch "ratchet-supervise-90"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?