didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Ratchet manifest + manifest_agent coverage to >=90% (ADR 0004) #299

Open
didericis-claude wants to merge 1 commits from ratchet-manifest-90 into ratchet-git-gate-90
pull from: ratchet-manifest-90
merge into: didericis:ratchet-git-gate-90
Conversation 0 Commits 1 Files Changed 1
+226
didericis-claude commented 2026-06-25 22:15:09 -04:00
Collaborator
Copy Link
Copy Source

Stacked on #298 (base = ratchet-git-gate-90). Fifth per-module ratchet under ADR 0004 — the manifest validation pair.

Summary

Drives the validation rejection / edge paths across both manifest modules:

  • ManifestBottle.from_dict — unknown key, non-string env value, non-bool supervise, removed runtime field.
  • ManifestAgentProvider.from_dict — unknown key, empty template, non-string dockerfile, auth_token / forward_host_credentials template constraints.
  • _parse_provider_settings — pass-through for non-built-in templates, startup_args shape, and the pi-specific string/int/bool/models/max_tokens_field/api-key-conflict checks.
  • ManifestAgent.from_dict — bottle empty/undefined, skills shape, prompt type, agent-level git-gate.repos rejection, empty git-gate allowed.
  • Eager ManifestIndex — empty bottles section, unknown-agent load, has_agent / require_agent, git_identity_summary (set and empty).

Coverage

Module Before After
manifest_agent.py 84% 99%
manifest.py 86% 94%

Remaining manifest.py misses are the lazy on-disk loader paths (exercised by the integration suite). 36 new tests; full suite (1478) passes; pyright clean; pylint 10.00.

Stacked on #298 (base = `ratchet-git-gate-90`). Fifth per-module ratchet under ADR 0004 — the manifest validation pair. ## Summary Drives the validation rejection / edge paths across both manifest modules: - **`ManifestBottle.from_dict`** — unknown key, non-string env value, non-bool supervise, removed `runtime` field. - **`ManifestAgentProvider.from_dict`** — unknown key, empty template, non-string dockerfile, `auth_token` / `forward_host_credentials` template constraints. - **`_parse_provider_settings`** — pass-through for non-built-in templates, `startup_args` shape, and the pi-specific string/int/bool/`models`/`max_tokens_field`/api-key-conflict checks. - **`ManifestAgent.from_dict`** — bottle empty/undefined, skills shape, prompt type, agent-level `git-gate.repos` rejection, empty `git-gate` allowed. - **Eager `ManifestIndex`** — empty bottles section, unknown-agent load, `has_agent` / `require_agent`, `git_identity_summary` (set and empty). ## Coverage | Module | Before | After | |---|---|---| | `manifest_agent.py` | 84% | **99%** | | `manifest.py` | 86% | **94%** | Remaining `manifest.py` misses are the lazy on-disk loader paths (exercised by the integration suite). 36 new tests; full suite (1478) passes; pyright clean; pylint 10.00.
didericis-claude added 1 commit 2026-06-25 22:15:10 -04:00
test(manifest): ratchet manifest + manifest_agent to >=90%
test / unit (pull_request) Successful in 46s
Details
test / integration (pull_request) Successful in 17s
Details
test / coverage (pull_request) Successful in 56s
Details
lint / lint (push) Successful in 1m54s
Details
74060192e0 
Fifth per-module ratchet under ADR 0004. Drive the validation
rejection and edge paths:

- ManifestBottle.from_dict: unknown key, non-string env value,
  non-bool supervise, removed `runtime` field.
- ManifestAgentProvider.from_dict: unknown key, empty template,
  non-string dockerfile, auth_token / forward_host_credentials
  template constraints.
- _parse_provider_settings: pass-through for non-built-in templates,
  startup_args shape, and the pi-specific string/int/bool/models/
  max_tokens_field/api-key-conflict checks.
- ManifestAgent.from_dict: bottle empty/undefined, skills shape, prompt
  type, agent-level git-gate.repos rejection, empty git-gate allowed.
- Eager ManifestIndex: empty bottles section, unknown-agent load,
  has_agent / require_agent, git_identity_summary (set and empty).

manifest_agent.py: 84% -> 99%; manifest.py: 86% -> 94%. Remaining
manifest.py misses are the lazy on-disk loader paths exercised by the
integration suite.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NkwFXLFff9PYPy4wgVBJp9
Some checks are pending
test / unit (pull_request) Successful in 46s
Details
test / integration (pull_request) Successful in 17s
Details
test / coverage (pull_request) Successful in 56s
Details
lint / lint (push) Successful in 1m54s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin ratchet-manifest-90:ratchet-manifest-90
git checkout ratchet-manifest-90
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#299
Delete Branch "ratchet-manifest-90"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?