didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Ratchet git_gate coverage to >=90% (ADR 0004) #298

Open
didericis-claude wants to merge 1 commits from ratchet-git-gate-90 into ratchet-egress-core-90
pull from: ratchet-git-gate-90
merge into: didericis:ratchet-egress-core-90
Conversation 0 Commits 1 Files Changed 1
+174
didericis-claude commented 2026-06-25 22:11:21 -04:00
Collaborator
Copy Link
Copy Source

Stacked on #297 (base = ratchet-egress-core-90). Fourth per-module ratchet under ADR 0004.

Summary

Covers two previously-untested halves of git_gate.py:

  • git_gate_render_gitconfig (pure renderer) — empty entries, insteadOf URL, scheme override, RemoteKey ssh-alias with and without a non-default port, and newline-injection rejection via _gitconfig_validate_value.
  • Dynamic gitea deploy-key lifecycle (forge provisioner mocked) — _provision_dynamic_key writes the key + key-id files, strips .git from owner/repo, builds the proposal title, and raises on a missing token; revoke_git_gate_provisioned_keys revokes when the id-file is present and skips static-provider entries / missing id-files / raises on missing token.

Coverage

Module Before After
git_gate.py 70% (unit) / 80% (combined) 99%

13 new tests; full suite (1442) passes; pyright clean; pylint 10.00.

Stacked on #297 (base = `ratchet-egress-core-90`). Fourth per-module ratchet under ADR 0004. ## Summary Covers two previously-untested halves of `git_gate.py`: - **`git_gate_render_gitconfig`** (pure renderer) — empty entries, `insteadOf` URL, scheme override, `RemoteKey` ssh-alias with and without a non-default port, and newline-injection rejection via `_gitconfig_validate_value`. - **Dynamic gitea deploy-key lifecycle** (forge provisioner mocked) — `_provision_dynamic_key` writes the key + key-id files, strips `.git` from owner/repo, builds the proposal title, and raises on a missing token; `revoke_git_gate_provisioned_keys` revokes when the id-file is present and skips static-provider entries / missing id-files / raises on missing token. ## Coverage | Module | Before | After | |---|---|---| | `git_gate.py` | 70% (unit) / 80% (combined) | **99%** | 13 new tests; full suite (1442) passes; pyright clean; pylint 10.00.
didericis-claude added 1 commit 2026-06-25 22:11:22 -04:00
test(git-gate): ratchet git_gate coverage to >=90%
test / unit (pull_request) Successful in 43s
Details
test / integration (pull_request) Successful in 17s
Details
test / coverage (pull_request) Successful in 58s
Details
lint / lint (push) Successful in 1m53s
Details
5365a7a852 
Fourth per-module ratchet under ADR 0004. Cover the pure
`git_gate_render_gitconfig` renderer (empty entries, insteadOf URL,
scheme override, RemoteKey ssh alias with/without non-default port,
newline-injection rejection) and the dynamic gitea deploy-key
lifecycle with the forge provisioner mocked:

- `_provision_dynamic_key`: writes key + key-id files, strips `.git`
  from owner/repo, builds the proposal title; missing token raises.
- `revoke_git_gate_provisioned_keys`: revokes a gitea key when the
  id-file is present, skips static-provider entries and missing
  id-files, raises on a missing token.

bot_bottle/git_gate.py: 70% -> 99% (unit only). Two remaining partial
branches are inner conditionals on the alias/owner-repo paths.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NkwFXLFff9PYPy4wgVBJp9
Some checks are pending
test / unit (pull_request) Successful in 43s
Details
test / integration (pull_request) Successful in 17s
Details
test / coverage (pull_request) Successful in 58s
Details
lint / lint (push) Successful in 1m53s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin ratchet-git-gate-90:ratchet-git-gate-90
git checkout ratchet-git-gate-90
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#298
Delete Branch "ratchet-git-gate-90"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?