didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Ratchet egress_addon_core coverage to >=90% (ADR 0004) #297

Open
didericis-claude wants to merge 1 commits from ratchet-egress-core-90 into ratchet-yaml-subset-90
pull from: ratchet-egress-core-90
merge into: didericis:ratchet-yaml-subset-90
Conversation 0 Commits 1 Files Changed 1
+297
didericis-claude commented 2026-06-25 22:04:44 -04:00
Collaborator
Copy Link
Copy Source

Stacked on #296 (base = ratchet-yaml-subset-90). Third per-module ratchet under ADR 0004.

Summary

Adds a parsing/serialization/evaluation suite for egress_addon_core — the heart of the egress engine:

  • Validation rejections — payload/route shape, missing host, auth scheme/token_env pairing, the git block, every matches sub-field (paths/methods/headers including type checks, regex-compile failures, unknown keys), and the dlp block (detector type/name, outbound_on_match, unknown key).
  • Valid round-trip — a fully-populated route parses; outbound_detectors: false disables.
  • parse_config log-level validation + load_config invalid-YAML.
  • route_to_yaml_dict — minimal / auth / git / dlp / matches with default-omission.
  • evaluate_matches — exact/prefix/regex paths, method filter, exact + regex header matching (match and non-match).

Coverage

Module Before After
egress_addon_core.py 84% 99%

The two remaining missed statements are defensive guards (an unreachable separator-return, a no-matching-path-type fallthrough). 53 new tests; full suite (1429) passes; pyright clean; pylint 9.81.

Stacked on #296 (base = `ratchet-yaml-subset-90`). Third per-module ratchet under ADR 0004. ## Summary Adds a parsing/serialization/evaluation suite for `egress_addon_core` — the heart of the egress engine: - **Validation rejections** — payload/route shape, missing host, auth `scheme`/`token_env` pairing, the `git` block, every `matches` sub-field (paths/methods/headers including type checks, regex-compile failures, unknown keys), and the `dlp` block (detector type/name, `outbound_on_match`, unknown key). - **Valid round-trip** — a fully-populated route parses; `outbound_detectors: false` disables. - **`parse_config`** log-level validation + **`load_config`** invalid-YAML. - **`route_to_yaml_dict`** — minimal / auth / git / dlp / matches with default-omission. - **`evaluate_matches`** — exact/prefix/regex paths, method filter, exact + regex header matching (match and non-match). ## Coverage | Module | Before | After | |---|---|---| | `egress_addon_core.py` | 84% | **99%** | The two remaining missed statements are defensive guards (an unreachable separator-return, a no-matching-path-type fallthrough). 53 new tests; full suite (1429) passes; pyright clean; pylint 9.81.
didericis-claude added 1 commit 2026-06-25 22:04:45 -04:00
test(egress): ratchet egress_addon_core coverage to >=90%
lint / lint (push) Successful in 1m51s
Details
test / unit (pull_request) Successful in 44s
Details
test / integration (pull_request) Successful in 16s
Details
test / coverage (pull_request) Successful in 57s
Details
f289b6382c 
Third per-module ratchet under ADR 0004. Add a parsing/serialization
suite for the egress engine's core:

- route validation rejections: payload/route shape, host, auth pairing,
  git block, every matches sub-field (paths/methods/headers type +
  regex-compile + unknown-key), and the dlp block (detector type/name,
  outbound_on_match, unknown key)
- a full valid route round-trips; detectors:false disables
- parse_config log-level validation + load_config invalid-YAML
- route_to_yaml_dict: minimal/auth/git/dlp/matches with default-omission
- evaluate_matches: exact/prefix/regex paths, method filter, exact +
  regex header matching (match and non-match)

egress_addon_core.py: 84% -> 99%. The two remaining missed statements
are defensive guards (an unreachable separator-return and a
no-matching-path-type fallthrough).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NkwFXLFff9PYPy4wgVBJp9
Some checks are pending
lint / lint (push) Successful in 1m51s
Details
test / unit (pull_request) Successful in 44s
Details
test / integration (pull_request) Successful in 16s
Details
test / coverage (pull_request) Successful in 57s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin ratchet-egress-core-90:ratchet-egress-core-90
git checkout ratchet-egress-core-90
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#297
Delete Branch "ratchet-egress-core-90"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?