didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Ratchet yaml_subset coverage to >=90% (ADR 0004) #296

Open
didericis-claude wants to merge 1 commits from ratchet-yaml-subset-90 into ratchet-egress-addon-90
pull from: ratchet-yaml-subset-90
merge into: didericis:ratchet-egress-addon-90
Conversation 0 Commits 1 Files Changed 1
+132
didericis-claude commented 2026-06-25 22:00:35 -04:00
Collaborator
Copy Link
Copy Source

Stacked on #295 (base = ratchet-egress-addon-90). Second per-module ratchet under ADR 0004.

Summary

Adds a branch-coverage suite for the hand-rolled YAML-subset parser, exercising its reachable error/edge cases:

  • scalars/comments: literal #, blank-line skipping, unterminated/bad-escape quotes
  • inline list/dict: unterminated, empty, missing-:, non-bare key, quoted comma in flow
  • block mapping/list: missing : separator, single-quoted/non-bare keys, list item at mapping indent, empty block → None, bare-dash nested lists, quoted-colon list scalars, nested & empty list-item mappings, duplicate / non-bare sibling keys
  • document-level rejections: block scalars (|/>), anchors (&), tags (!!), non-column-0 top level, top-level list; ampersand inside a quoted value still allowed
  • empty frontmatter

Coverage

Module Before After
yaml_subset.py 82% 95%

Remaining misses are dead/defensive guards (the unreachable true/false-in-reserved-set branch, indent-mismatch raises the callers never trigger). 32 new tests; full suite (1376) passes; pyright clean; pylint 9.96.

Stacked on #295 (base = `ratchet-egress-addon-90`). Second per-module ratchet under ADR 0004. ## Summary Adds a branch-coverage suite for the hand-rolled YAML-subset parser, exercising its reachable error/edge cases: - scalars/comments: literal `#`, blank-line skipping, unterminated/bad-escape quotes - inline list/dict: unterminated, empty, missing-`:`, non-bare key, quoted comma in flow - block mapping/list: missing `:` separator, single-quoted/non-bare keys, list item at mapping indent, empty block → `None`, bare-dash nested lists, quoted-colon list scalars, nested & empty list-item mappings, duplicate / non-bare sibling keys - document-level rejections: block scalars (`|`/`>`), anchors (`&`), tags (`!!`), non-column-0 top level, top-level list; ampersand inside a quoted value still allowed - empty frontmatter ## Coverage | Module | Before | After | |---|---|---| | `yaml_subset.py` | 82% | **95%** | Remaining misses are dead/defensive guards (the unreachable `true`/`false`-in-reserved-set branch, indent-mismatch raises the callers never trigger). 32 new tests; full suite (1376) passes; pyright clean; pylint 9.96.
didericis-claude added 1 commit 2026-06-25 22:00:36 -04:00
test(yaml): ratchet yaml_subset coverage to >=90%
lint / lint (push) Successful in 1m51s
Details
test / unit (pull_request) Successful in 45s
Details
test / integration (pull_request) Successful in 16s
Details
test / coverage (pull_request) Successful in 58s
Details
3073230f58 
Second per-module ratchet under ADR 0004. Add a branch-coverage suite
for the YAML-subset parser's reachable error/edge cases: literal `#`,
blank-line skipping, unterminated/empty/bad inline list+dict, quoted
commas in flow, missing `:` separators, non-bare keys, empty block ->
None, bare-dash nested lists, quoted-colon list scalars, nested/empty
list-item mappings, duplicate keys, document-level rejections
(block scalars, anchors, tags, non-column-0, top-level list), and
empty frontmatter.

yaml_subset.py: 82% -> 95%. The remaining misses are dead/defensive
guards (e.g. the unreachable bool branch, indent-mismatch raises that
the callers never trigger).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NkwFXLFff9PYPy4wgVBJp9
Some checks are pending
lint / lint (push) Successful in 1m51s
Details
test / unit (pull_request) Successful in 45s
Details
test / integration (pull_request) Successful in 16s
Details
test / coverage (pull_request) Successful in 58s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin ratchet-yaml-subset-90:ratchet-yaml-subset-90
git checkout ratchet-yaml-subset-90
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#296
Delete Branch "ratchet-yaml-subset-90"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?