bot-bottle

Author	SHA1	Message	Date
didericis-claude	c6d0642a94	refactor(types): move loaded manifest from BottleSpec to BottlePlan lint / lint (push) Successful in 1m35s Details test / unit (pull_request) Successful in 35s Details test / integration (pull_request) Successful in 19s Details BottleSpec.manifest was ManifestIndex \| Manifest — a union encoding two lifecycle stages in one field. The union was unjustifiable: it forced a type-narrowing workaround (loaded_manifest property) on every consumer. Clean split: - BottleSpec.manifest: ManifestIndex (always; CLI-supplied intent) - BottlePlan.manifest: Manifest (always; loaded by _validate()) _validate() returns the loaded Manifest directly. prepare() passes it to _resolve_plan(), which stores it on the plan. All provisioner code now reads plan.manifest.agent / plan.manifest.bottle — no union, no asserts, no type: ignore.	2026-06-22 23:43:08 -04:00
didericis-claude	5becef0d0b	fix(types): add BottleSpec.loaded_manifest to satisfy pyright on union type BottleSpec.manifest is ManifestIndex \| Manifest (pre/post _validate()). Downstream code always runs post-validate so it needs Manifest, but pyright flagged every .agent/.bottle access. The new loaded_manifest property asserts isinstance and returns Manifest, giving pyright a narrowed type without scattering type: ignore everywhere. Also remove unused Manifest imports from test files and annotate the _index() helper in test_manifest_agent_git_user.	2026-06-22 23:43:08 -04:00
didericis-claude	532072931f	refactor(manifest): split Manifest into ManifestIndex + Manifest single-value type Manifest now holds exactly one agent and one effective bottle (with git_user overlay already applied). The old multi-agent/bottle collection is renamed ManifestIndex. BottleSpec.manifest starts as ManifestIndex from the CLI and becomes Manifest after _validate() calls load_for_agent(); all provisioning code downstream reads spec.manifest.agent / spec.manifest.bottle instead of indexing by name.	2026-06-22 23:43:08 -04:00
didericis-claude	9ae49d21f7	docs: clarify load_for_agent invariant in docstring	2026-06-22 23:43:08 -04:00
didericis-claude	db712a523f	fix: load_for_agent always returns single-agent manifest Filter to exactly one agent and one bottle in both the lazy (md-dirs) and eager (from_json_obj) paths so the returned manifest invariant holds regardless of how the manifest was constructed.	2026-06-22 23:43:08 -04:00
didericis-claude	04f8019e75	refactor: scan filenames at resolve, parse only selected agent at preflight Manifest.resolve() now returns an empty-dict manifest with only directory paths recorded (home_md, cwd_md). No content is read from any .md file until load_for_agent() is called for a specific agent at preflight. - Manifest.from_md_dirs: scan-only, no frontmatter parsing - Manifest.load_for_agent: parses the selected agent file and its bottle chain; works on eager (from_json_obj) manifests too by returning self - Manifest.all_agent_names: scans filenames in lazy mode - backend._validate: calls load_for_agent and propagates upgraded spec - cli/info.py, cli/list.py, cli/start.py: use load_for_agent / all_agent_names - manifest_extends.py: reverted to original (no partial-resolve helpers) - manifest_loader.py: only scan_agent_names + load_bottle_chain_from_dir - Tests updated to call load_for_agent before accessing agents/bottles; test_md_agent_repos_deferred renamed to test_md_agent_repos_fails_at_preflight	2026-06-22 23:43:08 -04:00
didericis-claude	509adb7cbc	fix: resolve pyright reportUnusedImport in manifest_extends Import ManifestError at module level from manifest_util (no circular dep) and remove the redundant local imports from function bodies that were shadowing it. ManifestBottle retains its local import pattern to avoid the circular manifest ↔ manifest_extends dependency.	2026-06-22 23:43:08 -04:00
didericis-claude	21b3713264	feat: defer broken manifest parse errors to preflight Broken bottle/agent files no longer block the agent selector or prevent unrelated agents from loading. Per-file parse errors are collected in `Manifest.broken_agents`; the CLI selector includes them via `all_agent_names`, and the error surfaces only when the specific agent is selected and launch is attempted (in `require_agent`/`bottle_for`). Closes #236	2026-06-22 23:43:08 -04:00

1 changed files with 1 additions and 1 deletions

									
										README.md
									
		+1
		-1
	
												View File
												
					@@ -5,7 +5,7 @@

					# bot-bottle

					# bot-bottle

					[![test](https://gitea.dideric.is/didericis/bot-bottle/actions/workflows/test.yml/badge.svg?branch=main)](https://gitea.dideric.is/didericis/bot-bottle/actions?workflow=test.yml)

					[![test](https://gitea.dideric.is/didericis/bot-bottle/actions/workflows/test.yml/badge.svg?branch=main)](https://gitea.dideric.is/didericis/bot-bottle/actions?workflow=test.yml)

					[![pylint](https://img.shields.io/badge/pylint-9.93%2F10-brightgreen)](https://github.com/PyCQA/pylint)

					[![pylint](https://img.shields.io/badge/pylint-9.92%2F10-brightgreen)](https://github.com/PyCQA/pylint)

					[![pyright](https://img.shields.io/badge/pyright-0%20errors-brightgreen)](https://github.com/microsoft/pyright)

					[![pyright](https://img.shields.io/badge/pyright-0%20errors-brightgreen)](https://github.com/microsoft/pyright)

					**Problem:** Developer wants to run a coding agent without supervision, but they don't want a prompt injected or misbehaving agent wrecking their environment or exfiltrating sensitive data.

					**Problem:** Developer wants to run a coding agent without supervision, but they don't want a prompt injected or misbehaving agent wrecking their environment or exfiltrating sensitive data.

Compare commits

8 Commits

da42740156 .. c6d0642a94

Compare commits

8 Commits da42740156 .. c6d0642a94

8 Commits

da42740156 .. c6d0642a94