fix: add missing type annotations and remove unused variables in new tests
test / integration-docker (pull_request) Successful in 23s
test / unit (pull_request) Successful in 47s
lint / lint (push) Successful in 3m3s
test / integration-firecracker (pull_request) Successful in 3m24s
test / coverage (pull_request) Successful in 20s
test / publish-infra (pull_request) Has been skipped
tracker-policy-pr / check-pr (pull_request) Successful in 17s

Pyright flagged three inner class `status` methods missing a type
annotation on the `quiet` parameter, and two unused variables
(`written`, `real_status`) left over from an earlier draft of
test_docker_quiet_true_suppresses_stderr.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-07-24 06:18:51 +00:00
parent 05b62ce805
commit e074c6959f
2 changed files with 3 additions and 5 deletions
+3 -3
View File
@@ -409,7 +409,7 @@ class TestIsBackendReady(unittest.TestCase):
def test_ready_when_status_returns_zero(self):
class _ReadyBackend:
def status(self, *, quiet=False):
def status(self, *, quiet: bool = False) -> int:
return 0
from bot_bottle.backend import is_backend_ready
@@ -418,7 +418,7 @@ class TestIsBackendReady(unittest.TestCase):
def test_not_ready_when_status_nonzero(self):
class _BrokenBackend:
def status(self, *, quiet=False):
def status(self, *, quiet: bool = False) -> int:
return 1
from bot_bottle.backend import is_backend_ready
@@ -429,7 +429,7 @@ class TestIsBackendReady(unittest.TestCase):
calls = []
class _SpyBackend:
def status(self, *, quiet=False):
def status(self, *, quiet: bool = False) -> int:
calls.append(quiet)
return 0
-2
View File
@@ -342,8 +342,6 @@ class TestBackendStatusQuiet(unittest.TestCase):
def test_docker_quiet_true_suppresses_stderr(self):
import io as _io
from bot_bottle.backend.docker.backend import DockerBottleBackend
written = []
real_status = dk.status
def _loud_status():
import sys