Noticed a lot of shared logic in resolve_plan that should be in the base class even after prompting for consolidation. Going to look over the codebase and manually tidy up a bit.
@didericis-claude we shouldn't have multiple classes with the same name... actual class name is AgentProvider, even though it's a manifest. I thought it was the actual AgentProvider object…
We shouldn't be doing this/we already have the provider object on line 61.
This rename used to make sense, but not anymore: places where we're assigning image_default should be changed so we assign to image and we should just remove this image = image_default assignment.
A provider should always have a dockerfile now, so this else shouldn't be necessary.
This should always return a docker/should never return None
@didericis-claude no, remove it. Don't think we need it/overriding the image file seems unnecessary if we aren't using it in tests or in the wild. Can add it back if/when merited.