didericis
307400f08a
`/mcp` showed the supervise server as ✔ connected (initialize is fast), but any actual tool call failed because the supervise MCP design is long-poll — the sidecar holds the HTTP request open until the operator approves in the dashboard (potentially minutes) and only then returns the response. Pipelock is a forward proxy with idle timeouts; it cut the long- polled HTTPS-style request well before the operator could act, and claude-code reported the tool as ✘ failed. Fix: add `supervise` to the agent's NO_PROXY when bottle.supervise is true. The supervise sidecar is on the bottle's internal network with the `supervise` network-alias, so the agent can dial it directly via docker DNS — no proxy, no idle timeout. Body-scanning supervise traffic isn't critical because the operator reviews every proposal in the TUI before approving. The earlier pipelock allowlist auto-add for `supervise` stays as belt-and- braces (handles any proxy-respecting client other than claude-code that might dial supervise). Existing bottles need a restart to pick up the new NO_PROXY value (env can't be changed on a running container). The dashboard's pipelock-edit workaround from PR #25 unblocks short-running tool calls in the meantime but won't survive the pipelock idle timeout on a long-polled call. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
43 lines
1.2 KiB
Python
43 lines
1.2 KiB
Python
"""Unit: agent NO_PROXY value builder (PR #25 follow-up).
|
|
|
|
claude-code's HTTP MCP client must bypass pipelock for the supervise
|
|
sidecar — long-poll tool calls would hit pipelock's idle timeout
|
|
otherwise. This test pins the rule: localhost always; supervise iff
|
|
the supervise sidecar is in the plan."""
|
|
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
from claude_bottle.backend.docker.launch import _agent_no_proxy
|
|
|
|
|
|
class _FakePlan:
|
|
"""Just enough plan shape for the helper — no full DockerBottlePlan
|
|
construction needed."""
|
|
|
|
def __init__(self, supervise_plan):
|
|
self.supervise_plan = supervise_plan
|
|
|
|
|
|
class _SentinelSupervisePlan:
|
|
"""The helper only checks `supervise_plan is not None`; any object
|
|
is fine."""
|
|
|
|
|
|
class TestAgentNoProxy(unittest.TestCase):
|
|
def test_loopback_only_when_no_supervise(self):
|
|
self.assertEqual(
|
|
"localhost,127.0.0.1",
|
|
_agent_no_proxy(_FakePlan(supervise_plan=None)),
|
|
)
|
|
|
|
def test_supervise_appended_when_enabled(self):
|
|
self.assertEqual(
|
|
"localhost,127.0.0.1,supervise",
|
|
_agent_no_proxy(_FakePlan(supervise_plan=_SentinelSupervisePlan())),
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|