didericis
5465379654
Extract the Apple-Container control-plane lifecycle out of `MacosInfraService` into `MacosOrchestrator` (backend/macos_container/orchestrator.py): the container run on the host-only control network, the container-only DB volume, the source-hash recreate gate, health polling against the resolved control-network address, and `probe_orchestrator_url`. `url()` == `gateway_url()` here (Apple has no container DNS, so one resolved address serves the CLI and the gateway). `MacosInfraService` now composes `orchestrator()` + `gateway()`: ensure the networks, build both images (each service self-builds via `ensure_built` — added to `MacosGateway` too), bring the orchestrator up first, then connect the gateway with the orchestrator-minted token. `ORCHESTRATOR_IMAGE` + the DB-volume constant move to the orchestrator module (with back-compat aliases where imported). Container-lifecycle tests split into test_macos_orchestrator; test_macos_infra now covers the composition. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
82 lines
3.5 KiB
Python
82 lines
3.5 KiB
Python
"""Unit: MacosInfraService composes the orchestrator + gateway services.
|
|
|
|
`MacosInfraService` no longer owns the container lifecycles — it composes the
|
|
`MacosOrchestrator` (control plane) and `MacosGateway` (data plane) services,
|
|
each tested in its own module. These tests isolate the *composition*: the
|
|
networks are ensured, both images built, the orchestrator comes up first, then
|
|
the gateway is connected to it with a freshly minted token."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import unittest
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from bot_bottle.backend.macos_container.infra import MacosInfraService
|
|
|
|
_INFRA = "bot_bottle.backend.macos_container.infra"
|
|
|
|
|
|
class TestInfraEnsureRunning(unittest.TestCase):
|
|
def setUp(self) -> None:
|
|
self.svc = MacosInfraService(repo_root=Path("/r"))
|
|
self.orch = MagicMock()
|
|
self.orch.url.return_value = "http://192.168.128.2:8099"
|
|
self.orch.mint_gateway_token.return_value = "gw.jwt"
|
|
self.gw = MagicMock()
|
|
for name, mock in (("orchestrator", self.orch), ("gateway", self.gw)):
|
|
p = patch.object(self.svc, name, return_value=mock)
|
|
p.start()
|
|
self.addCleanup(p.stop)
|
|
|
|
def test_composes_networks_builds_and_brings_up_orchestrator_first(self) -> None:
|
|
with patch(f"{_INFRA}.ensure_networks") as nets, \
|
|
patch(f"{_INFRA}.container_mod") as mod:
|
|
mod.try_container_ipv4_on_network.return_value = "192.168.128.3"
|
|
endpoint = self.svc.ensure_running()
|
|
nets.assert_called_once()
|
|
self.orch.ensure_built.assert_called_once()
|
|
self.gw.ensure_built.assert_called_once()
|
|
self.orch.ensure_running.assert_called_once()
|
|
self.assertEqual("http://192.168.128.2:8099", endpoint.orchestrator_url)
|
|
self.assertEqual("192.168.128.3", endpoint.gateway_ip)
|
|
|
|
def test_connects_gateway_with_orchestrator_url_and_minted_token(self) -> None:
|
|
with patch(f"{_INFRA}.ensure_networks"), \
|
|
patch(f"{_INFRA}.container_mod") as mod:
|
|
mod.try_container_ipv4_on_network.return_value = "192.168.128.3"
|
|
self.svc.ensure_running()
|
|
self.gw.connect_to_orchestrator.assert_called_once_with(
|
|
"http://192.168.128.2:8099", "gw.jwt")
|
|
self.orch.mint_gateway_token.assert_called_once()
|
|
|
|
def test_is_healthy_delegates_to_the_orchestrator(self) -> None:
|
|
self.orch.is_healthy.return_value = True
|
|
self.assertTrue(self.svc.is_healthy())
|
|
self.orch.is_healthy.assert_called_once()
|
|
|
|
|
|
class TestCaCertPem(unittest.TestCase):
|
|
def test_delegates_to_the_gateway_service(self) -> None:
|
|
svc = MacosInfraService(repo_root=Path("/r"))
|
|
gw = MagicMock()
|
|
gw.ca_cert_pem.return_value = "-----BEGIN CERTIFICATE-----\n"
|
|
with patch.object(svc, "gateway", return_value=gw):
|
|
pem = svc.ca_cert_pem(timeout=5)
|
|
self.assertTrue(pem.startswith("-----BEGIN CERTIFICATE-----"))
|
|
gw.ca_cert_pem.assert_called_once_with(timeout=5)
|
|
|
|
|
|
class TestStop(unittest.TestCase):
|
|
def test_removes_both_containers(self) -> None:
|
|
svc = MacosInfraService(repo_root=Path("/r"))
|
|
with patch(f"{_INFRA}.container_mod") as mod:
|
|
svc.stop()
|
|
removed = {c.args[0] for c in mod.force_remove_container.call_args_list}
|
|
self.assertIn("bot-bottle-mac-infra", removed) # gateway
|
|
self.assertIn("bot-bottle-mac-orchestrator", removed) # orchestrator
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|