didericis
cd9f023f3d
prd-number-check / require-numbered-prds (pull_request) Successful in 11s
tracker-policy-pr / check-pr (pull_request) Successful in 14s
test / unit (pull_request) Successful in 59s
test / integration-docker (pull_request) Successful in 1m6s
test / coverage (push) Successful in 21s
test / image-input-builds (push) Successful in 44s
test / image-input-builds (pull_request) Successful in 1m15s
test / unit (push) Successful in 57s
test / coverage (pull_request) Successful in 20s
lint / lint (push) Successful in 1m3s
Update Quality Badges / update-badges (push) Successful in 1m12s
test / integration-docker (push) Successful in 1m0s
`doctor` told users to run `./cli.py backend setup`. cli.py is a four-line wrapper at the repo root that calls bot_bottle.cli:main, and it does not ship — [tool.setuptools.packages.find] includes only bot_bottle*, so anyone who installed rather than cloned has no such file. Confirmed against a real install: the user's tree contains exactly one executable, `bot-bottle`, and no cli.py anywhere, while doctor recommended `./cli.py` three times. Invisible in development, where ./cli.py works fine from a checkout, which is why only a clean-install test surfaced it. The two entry points are the same code, so the fix is to name the one that always exists. 141 replacements across 45 files: the runtime messages that caused this, plus README, docs, PRDs, research notes and test prose, so nothing teaches the invocation a user cannot run. scripts/demo.sh is deliberately untouched — it *executes* ./cli.py from a checkout, where that is the correct and available path. Verified end to end: a sandbox install now reports "Run: bot-bottle backend setup --backend=firecracker", and bot-bottle is on that user's PATH. Unit suite unchanged against the pre-existing baseline. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WEfZZhakx13bxTfXcZCoS5
79 lines
3.1 KiB
Python
79 lines
3.1 KiB
Python
"""Tests for the backend-aware skip guards in ``tests/_backend.py``.
|
|
|
|
The guards delegate their readiness check to
|
|
``bot_bottle.backend.is_backend_ready`` (the probe behind ``bot-bottle backend
|
|
status``); here that probe is mocked so the unit job asserts the
|
|
selection/skip logic without either backend present on the runner.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
from tests._backend import (
|
|
selected_backend,
|
|
skip_unless_backend,
|
|
skip_unless_selected_backend_available,
|
|
)
|
|
|
|
|
|
def _skipped(decorated: type) -> bool:
|
|
return getattr(decorated, "__unittest_skip__", False)
|
|
|
|
|
|
def _new_case() -> type:
|
|
return type("Case", (unittest.TestCase,), {})
|
|
|
|
|
|
class TestSelectedBackend(unittest.TestCase):
|
|
def test_defaults_to_docker_when_unset(self):
|
|
with patch.dict(os.environ, {}, clear=True):
|
|
self.assertEqual("docker", selected_backend())
|
|
|
|
def test_reads_env(self):
|
|
with patch.dict(os.environ, {"BOT_BOTTLE_BACKEND": "firecracker"}, clear=True):
|
|
self.assertEqual("firecracker", selected_backend())
|
|
|
|
|
|
class TestSkipUnlessBackend(unittest.TestCase):
|
|
def test_skips_when_other_backend_selected(self):
|
|
# A different backend is selected — no host probe needed, skip.
|
|
with patch.dict(os.environ, {"BOT_BOTTLE_BACKEND": "firecracker"}, clear=True), \
|
|
patch("tests._backend.is_backend_ready") as has:
|
|
decorated = skip_unless_backend("docker")(_new_case())
|
|
self.assertTrue(_skipped(decorated))
|
|
has.assert_not_called()
|
|
|
|
def test_runs_when_selected_and_available(self):
|
|
with patch.dict(os.environ, {"BOT_BOTTLE_BACKEND": "docker"}, clear=True), \
|
|
patch("tests._backend.is_backend_ready", return_value=True):
|
|
decorated = skip_unless_backend("docker")(_new_case())
|
|
self.assertFalse(_skipped(decorated))
|
|
|
|
def test_skips_when_selected_but_unavailable(self):
|
|
with patch.dict(os.environ, {"BOT_BOTTLE_BACKEND": "docker"}, clear=True), \
|
|
patch("tests._backend.is_backend_ready", return_value=False):
|
|
decorated = skip_unless_backend("docker")(_new_case())
|
|
self.assertTrue(_skipped(decorated))
|
|
|
|
|
|
class TestSkipUnlessSelectedBackendAvailable(unittest.TestCase):
|
|
def test_runs_when_selected_backend_available(self):
|
|
with patch.dict(os.environ, {"BOT_BOTTLE_BACKEND": "firecracker"}, clear=True), \
|
|
patch("tests._backend.is_backend_ready", return_value=True) as has:
|
|
decorated = skip_unless_selected_backend_available()(_new_case())
|
|
self.assertFalse(_skipped(decorated))
|
|
has.assert_called_once_with("firecracker", quiet=False)
|
|
|
|
def test_skips_when_selected_backend_unavailable(self):
|
|
with patch.dict(os.environ, {"BOT_BOTTLE_BACKEND": "firecracker"}, clear=True), \
|
|
patch("tests._backend.is_backend_ready", return_value=False):
|
|
decorated = skip_unless_selected_backend_available()(_new_case())
|
|
self.assertTrue(_skipped(decorated))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|