didericis
edd8b444a6
test / run tests/run_tests.py (pull_request) Successful in 18s
PipelockProxy becomes an ABC with the platform-agnostic
prepare/_build_pipelock_yaml as concrete methods and start/stop as
abstract. Docker-specific sidecar lifecycle moves to a new sibling
file:
claude_bottle/backend/docker/pipelock.py
DockerPipelockProxy(PipelockProxy) — implements start (docker
create/cp/network connect/start) and stop (docker inspect/rm -f).
DockerBottleBackend._proxy is now a DockerPipelockProxy instance.
Tests that previously instantiated PipelockProxy() directly switch to
DockerPipelockProxy() (the base is no longer constructable).
83 lines
3.1 KiB
Python
83 lines
3.1 KiB
Python
"""Unit: PipelockProxy.prepare — produces a pipelock YAML config
|
|
containing the expected top-level keys and per-bottle entries. We
|
|
don't fully parse YAML; we grep for content shape."""
|
|
|
|
import os
|
|
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
from claude_bottle.backend.docker.pipelock import DockerPipelockProxy
|
|
from claude_bottle.manifest import Manifest
|
|
from tests.fixtures import fixture_minimal, fixture_with_ssh
|
|
|
|
|
|
class TestPipelockProxyPrepare(unittest.TestCase):
|
|
def setUp(self):
|
|
self.out_dir = Path(tempfile.mkdtemp())
|
|
self.proxy = DockerPipelockProxy()
|
|
|
|
def tearDown(self):
|
|
import shutil
|
|
shutil.rmtree(self.out_dir, ignore_errors=True)
|
|
|
|
def test_minimal(self):
|
|
yaml_path = self.out_dir / "min.yaml"
|
|
self.proxy.prepare(fixture_minimal(), "dev", "demo", yaml_path)
|
|
content = yaml_path.read_text()
|
|
self.assertIn("mode: strict", content)
|
|
self.assertIn("enforce: true", content)
|
|
self.assertIn("api_allowlist:", content)
|
|
self.assertIn("api.anthropic.com", content)
|
|
self.assertIn("raw.githubusercontent.com", content)
|
|
self.assertIn("forward_proxy:", content)
|
|
self.assertIn("enabled: true", content)
|
|
self.assertIn("dlp:", content)
|
|
self.assertIn("include_defaults: true", content)
|
|
self.assertIn("scan_env: true", content)
|
|
# No ssh entries → no trusted_domains nor ssrf block.
|
|
self.assertNotIn("trusted_domains:", content)
|
|
self.assertNotIn("ssrf:", content)
|
|
|
|
def test_ssh_blocks(self):
|
|
yaml_path = self.out_dir / "ssh.yaml"
|
|
self.proxy.prepare(fixture_with_ssh(), "dev", "demo", yaml_path)
|
|
content = yaml_path.read_text()
|
|
self.assertIn("trusted_domains:", content)
|
|
self.assertIn("github.com", content)
|
|
self.assertIn("ssrf:", content)
|
|
self.assertIn("ip_allowlist:", content)
|
|
self.assertIn("100.78.141.42/32", content)
|
|
# ipv4 host should also be in api_allowlist (strict mode requires both).
|
|
self.assertIn("100.78.141.42", content)
|
|
|
|
def test_secret_hygiene(self):
|
|
manifest = Manifest.from_json_obj({
|
|
"bottles": {
|
|
"dev": {
|
|
"env": {
|
|
"MY_SECRET": "literal-value-should-not-appear",
|
|
"ANOTHER": "?prompt-message",
|
|
},
|
|
"egress": {"allowlist": ["github.com"]},
|
|
}
|
|
},
|
|
"agents": {"demo": {"skills": [], "prompt": "", "bottle": "dev"}},
|
|
})
|
|
yaml_path = self.out_dir / "secret.yaml"
|
|
self.proxy.prepare(manifest, "dev", "demo", yaml_path)
|
|
content = yaml_path.read_text()
|
|
self.assertNotIn("literal-value-should-not-appear", content)
|
|
self.assertNotIn("MY_SECRET", content)
|
|
self.assertNotIn("prompt-message", content)
|
|
|
|
def test_file_mode_is_600(self):
|
|
yaml_path = self.out_dir / "min.yaml"
|
|
self.proxy.prepare(fixture_minimal(), "dev", "demo", yaml_path)
|
|
mode = os.stat(yaml_path).st_mode & 0o777
|
|
self.assertEqual(0o600, mode)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|