didericis-claude
847baa84be
Review feedback on #102: a manifest that can't be read should raise an exception, not call die() (a SystemExit). That SystemExit was the whole reason the dashboard had to special-case Die. manifest.py now raises ManifestError (a plain Exception) for every validation failure. The CLI dispatcher catches it and prints+exits 1 (same UX as before); the dashboard catches it with a normal `except ManifestError` and degrades to a status-line warning. Manifest tests assert on ManifestError + its message. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
40 lines
1.3 KiB
Python
40 lines
1.3 KiB
Python
"""Unit: bottle 'runtime' field is no longer supported (PRD 0003).
|
|
|
|
gVisor is now auto-detected by the Docker factory. A manifest carrying
|
|
the legacy 'runtime' field must fail, regardless of value, rather than
|
|
silently ignoring."""
|
|
|
|
import unittest
|
|
from typing import Any
|
|
|
|
from bot_bottle.manifest import ManifestError, Bottle, Manifest
|
|
|
|
|
|
def _manifest_with_runtime(value: object) -> dict[str, Any]:
|
|
return {
|
|
"bottles": {"dev": {"runtime": value}},
|
|
"agents": {"demo": {"skills": [], "prompt": "", "bottle": "dev"}},
|
|
}
|
|
|
|
|
|
class TestManifestRuntimeRemoved(unittest.TestCase):
|
|
def test_loads_when_runtime_absent(self):
|
|
m = Manifest.from_json_obj({
|
|
"bottles": {"dev": {}},
|
|
"agents": {"demo": {"skills": [], "prompt": "", "bottle": "dev"}},
|
|
})
|
|
self.assertIn("dev", m.bottles)
|
|
|
|
def test_bottle_dataclass_has_no_runtime_attribute(self):
|
|
self.assertFalse(hasattr(Bottle(), "runtime"))
|
|
|
|
def test_any_runtime_value_is_rejected(self):
|
|
for value in ("runsc", "runc", "kata-runtime", "", 42, None):
|
|
with self.subTest(value=value):
|
|
with self.assertRaises(ManifestError):
|
|
Manifest.from_json_obj(_manifest_with_runtime(value))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|