didericis/bot-bottle
1
0
Fork 0
Code Issues 34 Pull Requests 17 Actions 2 Packages Releases Wiki Activity

Disable AGit review refs at git-gate #506

New Issue
Closed
opened 2026-07-26 13:52:47 -04:00 by didericis-codex · 0 comments
didericis-codex commented 2026-07-26 13:52:47 -04:00
Collaborator
Copy Link
Copy Source

Problem

Gitea AGit accepts pushes to refs/for/*, refs/draft/*, and refs/for-review/* and creates pull requests backed by server-managed review refs rather than normal refs/heads/* branches.

That conflicts with bot-bottle’s git-gate workflow:

  • follow-up commits cannot be pushed to the PR through the normal branch workflow;
  • git-gate can forward creation of the AGit review ref, but Gitea rejects later direct updates to the generated refs/pull/<n>/head;
  • agents and operators cannot reliably fetch, amend, and push the source branch because no ordinary source branch exists;
  • recovery requires creating a replacement branch-backed PR, losing continuity and creating avoidable review churn.

Desired behavior

Git-gate should reject creation or updates of AGit review refs and instruct callers to push to refs/heads/<branch> before opening a pull request. Normal branches and tags must remain unaffected. Deletion of old AGit refs should remain allowed for cleanup.

Acceptance criteria

  • pushes creating or updating refs/for/*, refs/draft/*, or refs/for-review/* fail before scanning or upstream forwarding;
  • the rejection message explains the branch-backed PR workflow;
  • deletion of legacy AGit refs remains possible;
  • focused unit coverage verifies the guard.
## Problem Gitea AGit accepts pushes to `refs/for/*`, `refs/draft/*`, and `refs/for-review/*` and creates pull requests backed by server-managed review refs rather than normal `refs/heads/*` branches. That conflicts with bot-bottle’s git-gate workflow: - follow-up commits cannot be pushed to the PR through the normal branch workflow; - git-gate can forward creation of the AGit review ref, but Gitea rejects later direct updates to the generated `refs/pull/<n>/head`; - agents and operators cannot reliably fetch, amend, and push the source branch because no ordinary source branch exists; - recovery requires creating a replacement branch-backed PR, losing continuity and creating avoidable review churn. ## Desired behavior Git-gate should reject creation or updates of AGit review refs and instruct callers to push to `refs/heads/<branch>` before opening a pull request. Normal branches and tags must remain unaffected. Deletion of old AGit refs should remain allowed for cleanup. ## Acceptance criteria - pushes creating or updating `refs/for/*`, `refs/draft/*`, or `refs/for-review/*` fail before scanning or upstream forwarding; - the rejection message explains the branch-backed PR workflow; - deletion of legacy AGit refs remains possible; - focused unit coverage verifies the guard.
gitea-actions bot added the Status/Needs Triage label 2026-07-26 13:52:55 -04:00
didericis added
Priority
Critical
1
Kind/Security and removed Status/Needs Triage labels 2026-07-26 13:56:05 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status/Needs Triage
Awaiting initial classification
No Label Kind/Security
Priority
Critical
1
Milestone
No items
No Milestone
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#506
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?