didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

feat(dashboard): spawn claude in new tmux window when $TMUX is set #48

Closed
didericis wants to merge 1 commits from tmux-spawn-window into main
pull from: tmux-spawn-window
merge into: didericis:main
Conversation 0 Commits 1 Files Changed 3
+95 -11
didericis commented 2026-05-26 14:05:06 -04:00
Owner
Copy Link
Copy Source

Summary

Option 3 from docs/research/claude-code-pane-in-dashboard.md, opt-in by environment. When the dashboard runs inside tmux (\$TMUX is set), both the new-agent (n) attach AND the re-attach (Enter) paths spawn claude with tmux new-window -n <slug> docker exec -it … claude … instead of taking over the terminal via curses.endwin. The dashboard keeps rendering in its current tmux pane; the operator switches to the new window via tmux's normal nav (default C-b n).

Outside tmux, the existing handoff path is unchanged — the dispatch is a single _in_tmux() check per attach.

Mechanics

  • DockerBottle.claude_docker_argv extracted from exec_claude, so both subprocess.run AND tmux new-window can build on the same docker-exec argv (preserving --append-system-prompt-file).
  • _attach_via_tmux in dashboard.py wraps the docker argv with tmux new-window -n <slug> … and returns immediately. Status line: [slug] opened in new tmux window.
  • _build_tmux_attach_argv split out as a pure helper so the wrapping shape is unit-tested without shelling out.

Status

  • 467 unit tests pass (2 new for _build_tmux_attach_argv)
  • No regression for the non-tmux path; existing handoff used when \$TMUX is unset
## Summary Option 3 from `docs/research/claude-code-pane-in-dashboard.md`, opt-in by environment. When the dashboard runs inside tmux (`\$TMUX` is set), both the new-agent (`n`) attach AND the re-attach (Enter) paths spawn claude with `tmux new-window -n <slug> docker exec -it … claude …` instead of taking over the terminal via `curses.endwin`. The dashboard keeps rendering in its current tmux pane; the operator switches to the new window via tmux's normal nav (default `C-b n`). Outside tmux, the existing handoff path is unchanged — the dispatch is a single `_in_tmux()` check per attach. ## Mechanics - `DockerBottle.claude_docker_argv` extracted from `exec_claude`, so both `subprocess.run` AND `tmux new-window` can build on the same docker-exec argv (preserving `--append-system-prompt-file`). - `_attach_via_tmux` in dashboard.py wraps the docker argv with `tmux new-window -n <slug> …` and returns immediately. Status line: `[slug] opened in new tmux window`. - `_build_tmux_attach_argv` split out as a pure helper so the wrapping shape is unit-tested without shelling out. ## Status - 467 unit tests pass (2 new for `_build_tmux_attach_argv`) - No regression for the non-tmux path; existing handoff used when `\$TMUX` is unset
didericis added 1 commit 2026-05-26 14:05:07 -04:00
feat(dashboard): spawn claude in new tmux window when \$TMUX is set
test / unit (pull_request) Successful in 18s
Details
test / integration (pull_request) Successful in 1m10s
Details
62ceab7485 
Option 3 from `docs/research/claude-code-pane-in-dashboard.md`,
opt-in by environment. When the dashboard runs inside tmux
(\$TMUX is set), both the new-agent (`n`) attach AND the
re-attach (Enter) paths spawn claude with
`tmux new-window -n <slug> docker exec -it … claude …` instead
of taking over the terminal via `curses.endwin`. The dashboard
keeps rendering in its current tmux pane; the operator switches
to the new window via tmux's normal nav.

Outside tmux the existing handoff path is unchanged — the
dispatch is a single `_in_tmux()` check per attach.

Mechanics:

  - `DockerBottle.claude_docker_argv` extracted from `exec_claude`,
    so both subprocess.run AND `tmux new-window` can build on the
    same docker-exec argv (preserving `--append-system-prompt-file`).
  - `_attach_via_tmux` in dashboard.py wraps the docker argv with
    `tmux new-window -n <slug> …` and returns immediately. Status
    line: `[slug] opened in new tmux window`.
  - `_build_tmux_attach_argv` split out as a pure helper so the
    wrapping shape is unit-tested without shelling out.

467 unit tests pass (2 new for `_build_tmux_attach_argv`).
didericis closed this pull request 2026-05-26 14:16:59 -04:00
Some checks are pending
test / unit (pull_request) Successful in 18s
Details
test / integration (pull_request) Successful in 1m10s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#48
Delete Branch "tmux-spawn-window"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?