didericis/bot-bottle
1
0
Fork 0
Code Issues 26 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

refactor(orchestrator): slice 9 — rename Sidecar → Gateway for the consolidated data plane #364

Closed
didericis-claude wants to merge 1 commits from orchestrator-rename-gateway into orchestrator-slice8
pull from: orchestrator-rename-gateway
merge into: didericis:orchestrator-slice8
Conversation 2 Commits 1 Files Changed 17
+151 -151
didericis-claude commented 2026-07-13 18:12:55 -04:00
Collaborator
Copy Link
Copy Source

Retire "sidecar" for the consolidated per-host path, per the PRD 0070 naming decision: the orchestrator is the umbrella/control plane, and the egress/git/supervise data-plane unit it runs is the gateway.

What changed

  • git mv sidecar.py -> gateway.py plus the two integration + one unit test files (rename-tracked).
  • Identifiers: DockerSidecar->DockerGateway, Sidecar->Gateway, SidecarError->GatewayError, SIDECAR_*->GATEWAY_*, ensure_sidecar->ensure_gateway, sidecar_status->gateway_status, container name bot-bottle-orch-sidecar->bot-bottle-orch-gateway.
  • Prose rename across broker.py, registry.py, egress_addon*.py, policy_resolver.py, and PRD 0070.

Deliberately preserved

  • The built image name bot-bottle-sidecars, the BOT_BOTTLE_SIDECAR_IMAGE env var, and Dockerfile.sidecars (image/artifact names unchanged — no rebuild churn).
  • PRD 0069's own stage-name cross-references (that doc still uses "sidecar").
  • test_sidecar_init (the in-bottle supervise/init supervisor) is a separate component, out of scope.

Verification

No behavior change. Full unit suite green — 1679 tests; the 13 test_sidecar_init /bin/sleep errors are pre-existing NixOS-local noise. Import surface re-verified.

🤖 Generated with Claude Code

Retire "sidecar" for the consolidated per-host path, per the PRD 0070 naming decision: the **orchestrator** is the umbrella/control plane, and the egress/git/supervise **data-plane unit** it runs is the **gateway**. ### What changed - `git mv sidecar.py -> gateway.py` plus the two integration + one unit test files (rename-tracked). - Identifiers: `DockerSidecar->DockerGateway`, `Sidecar->Gateway`, `SidecarError->GatewayError`, `SIDECAR_*->GATEWAY_*`, `ensure_sidecar->ensure_gateway`, `sidecar_status->gateway_status`, container name `bot-bottle-orch-sidecar->bot-bottle-orch-gateway`. - Prose rename across `broker.py`, `registry.py`, `egress_addon*.py`, `policy_resolver.py`, and PRD 0070. ### Deliberately preserved - The built image name `bot-bottle-sidecars`, the `BOT_BOTTLE_SIDECAR_IMAGE` env var, and `Dockerfile.sidecars` (image/artifact names unchanged — no rebuild churn). - PRD 0069's own stage-name cross-references (that doc still uses "sidecar"). - `test_sidecar_init` (the in-bottle supervise/init supervisor) is a separate component, out of scope. ### Verification No behavior change. Full unit suite green — 1679 tests; the 13 `test_sidecar_init` `/bin/sleep` errors are pre-existing NixOS-local noise. Import surface re-verified. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
didericis-claude added 1 commit 2026-07-13 18:12:58 -04:00
refactor(orchestrator): rename Sidecar -> Gateway for the consolidated data plane
test / unit (pull_request) Successful in 1m10s
Details
test / integration (pull_request) Successful in 25s
Details
test / coverage (pull_request) Successful in 1m17s
Details
lint / lint (push) Successful in 2m11s
Details
e0b0429cd1 
Retire "sidecar" for the consolidated per-host path (PRD 0070 naming
decision): the orchestrator is the umbrella/control plane, and the
egress/git/supervise data-plane unit it runs is the "gateway".

- git mv sidecar.py -> gateway.py and the two integration + one unit test
  files; DockerSidecar->DockerGateway, Sidecar->Gateway,
  SidecarError->GatewayError, SIDECAR_*->GATEWAY_*, ensure_sidecar->
  ensure_gateway, sidecar_status->gateway_status, container name
  bot-bottle-orch-sidecar->bot-bottle-orch-gateway.
- Prose rename across broker/registry/egress/policy_resolver + PRD 0070.
- Preserved: the image name bot-bottle-sidecars, the
  BOT_BOTTLE_SIDECAR_IMAGE env var, Dockerfile.sidecars, and PRD 0069's
  own stage-name cross-references (that doc still uses "sidecar").

No behavior change. Full unit suite green (1679 tests; the 13
test_sidecar_init /bin/sleep errors are pre-existing NixOS-local noise).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WBMWTEtQdJ4W5UrWuLHCck
didericis approved these changes 2026-07-13 18:23:51 -04:00
didericis-claude changed title from refactor(orchestrator): rename Sidecar -> Gateway for the consolidated data plane to refactor(orchestrator): slice 9 — rename Sidecar → Gateway for the consolidated data plane 2026-07-13 19:33:37 -04:00
didericis-claude commented 2026-07-14 00:57:24 -04:00
Author
Collaborator
Copy Link
Copy Source

Collapsed into the single stack PR #380 (per-host orchestrator, PRD 0070). Closing this slice PR; review + merge happens on #380.

Collapsed into the single stack PR #380 (per-host orchestrator, PRD 0070). Closing this slice PR; review + merge happens on #380.
didericis-claude closed this pull request 2026-07-14 00:57:25 -04:00
Some checks are pending
test / unit (pull_request) Successful in 1m10s
Details
test / integration (pull_request) Successful in 25s
Details
test / coverage (pull_request) Successful in 1m17s
Details
lint / lint (push) Successful in 2m11s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
didericis
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#364
Delete Branch "orchestrator-rename-gateway"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?