didericis/bot-bottle
1
0
Fork 0
Code Issues 36 Pull Requests 3 Actions Packages Releases Wiki Activity

Remove cli backend assumptions #344

New Issue
Closed
opened 2026-07-11 12:44:39 -04:00 by didericis · 0 comments
didericis commented 2026-07-11 12:44:39 -04:00
Owner
Copy Link
Copy Source

Tried running ./cli.py cleanup on linux, hit an error about the macos backend being unsupported. Must have missed some hardcoded macos backend assumptions in the cli. Should search for any assumptions like that and remove them.

Also let's consolidate the backend selection logic:

  1. Remove the --backend flag/only drive backend usage from the env var (or default selection)
  2. When no env var is set, we should search for the first available backend

RE first available backend, there should be a two tiered search:

  1. Search for a VM backend (firecracker on linux, macos containers on mac)
  2. Fall back to docker

RE falling back to docker, we should warn the user that docker is less secure, and prompt the user to install either firecracker or macos containers (depending on the platform), to ignore the warning/use docker, or to quit. When docker is unavailable, should also prompt the user to install either firecracker or macos containers (use the same function to display install commands as the former flow) and then quit.

Tried running `./cli.py cleanup` on linux, hit an error about the macos backend being unsupported. Must have missed some hardcoded macos backend assumptions in the cli. Should search for any assumptions like that and remove them. Also let's consolidate the backend selection logic: 1. Remove the `--backend` flag/only drive backend usage from the env var (or default selection) 2. When no env var is set, we should search for the first available backend RE first available backend, there should be a two tiered search: 1. Search for a VM backend (firecracker on linux, macos containers on mac) 2. Fall back to docker RE falling back to docker, we should warn the user that docker is less secure, and prompt the user to install either firecracker or macos containers (depending on the platform), to ignore the warning/use docker, or to quit. When docker is unavailable, should also prompt the user to install either firecracker or macos containers (use the same function to display install commands as the former flow) and then quit.
didericis added the Kind/Bug label 2026-07-11 12:44:39 -04:00
didericis added the
Priority
Critical
1
 label 2026-07-18 03:39:44 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status/Needs Triage
Awaiting initial classification
No Label Kind/Bug
Priority
Critical
1
Milestone
No items
No Milestone
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#344
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?