didericis/bot-bottle
1
0
Fork 0
Code Issues 5 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Make audit-log tests hermetic (temp HOME) #302

New Issue
Closed
opened 2026-06-26 20:30:55 -04:00 by didericis-claude · 0 comments
didericis-claude commented 2026-06-26 20:30:55 -04:00
Collaborator
Copy Link
Copy Source

From quality-eval (medium priority; the item holding Testability at 4).

Tests exercising write_audit_entry / read_audit_entries / audit_log_path in tests/unit/test_supervise.py write to the real ~/.bot-bottle and take a flock. A full coverage run hangs at 0% CPU when a live bottle's supervise sidecar holds that lock (observed). Non-hermetic / non-deterministic.

Task: Pin HOME to a tempfile.TemporaryDirectory() (setUp / patch.dict) for those tests so they never touch the real home dir or block on an unrelated lock.

No PRD required (test fix).

From quality-eval (medium priority; the item holding Testability at 4). Tests exercising `write_audit_entry` / `read_audit_entries` / `audit_log_path` in `tests/unit/test_supervise.py` write to the **real** `~/.bot-bottle` and take a `flock`. A full `coverage run` hangs at 0% CPU when a live bottle's supervise sidecar holds that lock (observed). Non-hermetic / non-deterministic. **Task:** Pin `HOME` to a `tempfile.TemporaryDirectory()` (setUp / patch.dict) for those tests so they never touch the real home dir or block on an unrelated lock. No PRD required (test fix).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#302
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?