didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Decompose egress_addon_core.py detector-config parsing #287

New Issue
Open
opened 2026-06-25 19:24:55 -04:00 by didericis-claude · 0 comments
didericis-claude commented 2026-06-25 19:24:55 -04:00
Collaborator
Copy Link
Copy Source

From quality-eval audit (medium priority).

bot_bottle/egress_addon_core.py is 862 LOC and mixes detector-config parsing/validation (_parse_detectors, outbound_on_match schema checks) with the runtime scan/decision flow.

Task: Split detector-config parsing/validation into its own module so the request-time decision path reads top-to-bottom without scrolling past config plumbing. Pure refactor; behavior unchanged.

No PRD required (refactor).

From quality-eval audit (medium priority). `bot_bottle/egress_addon_core.py` is 862 LOC and mixes detector-config parsing/validation (`_parse_detectors`, `outbound_on_match` schema checks) with the runtime scan/decision flow. **Task:** Split detector-config parsing/validation into its own module so the request-time decision path reads top-to-bottom without scrolling past config plumbing. Pure refactor; behavior unchanged. No PRD required (refactor).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#287
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?