didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Refactor manifest.py into domain-specific modules #157

New Issue
Closed
opened 2026-06-02 22:30:43 -04:00 by didericis-claude · 0 comments
didericis-claude commented 2026-06-02 22:30:43 -04:00
Collaborator
Copy Link
Copy Source

Tracked from the medium-priority refactoring playbook in #154.

manifest.py is 1,036 lines and carries git identity, egress routing, agent configuration, and top-level manifest parsing in a single file. The size and mixed domain responsibility make it harder to navigate and extend.

Proposed split

  • manifest_git.py — GitEntry, GitUser, and related parsing/validation helpers
  • manifest_egress.py — EgressRoute, PipelockRoutePolicy, and related helpers
  • manifest_agent.py — Agent, AgentProvider, and related helpers
  • manifest.py (residual) — Manifest, Bottle, and top-level orchestration that composes the above

Work

  • Move classes into the new modules, keeping manifest.py as the public import surface (re-export from the new modules) so existing callers do not need updating in the same PR.
  • Confirm all 863 unit tests still pass after the split.
  • No behavioral changes.
Tracked from the medium-priority refactoring playbook in #154. `manifest.py` is 1,036 lines and carries git identity, egress routing, agent configuration, and top-level manifest parsing in a single file. The size and mixed domain responsibility make it harder to navigate and extend. ## Proposed split - `manifest_git.py` — `GitEntry`, `GitUser`, and related parsing/validation helpers - `manifest_egress.py` — `EgressRoute`, `PipelockRoutePolicy`, and related helpers - `manifest_agent.py` — `Agent`, `AgentProvider`, and related helpers - `manifest.py` (residual) — `Manifest`, `Bottle`, and top-level orchestration that composes the above ## Work - Move classes into the new modules, keeping `manifest.py` as the public import surface (re-export from the new modules) so existing callers do not need updating in the same PR. - Confirm all 863 unit tests still pass after the split. - No behavioral changes.
didericis added the Kind/Enhancement label 2026-06-02 23:33:19 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Kind/Enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#157
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?