didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

Replace silent BaseException swallowing in Docker teardown with structured warning capture #156

New Issue
Closed
opened 2026-06-02 22:30:42 -04:00 by didericis-claude · 0 comments
didericis-claude commented 2026-06-02 22:30:42 -04:00
Collaborator
Copy Link
Copy Source

Tracked from the medium-priority refactoring playbook in #154.

Docker teardown catches BaseException and discards it silently, which can hide cleanup failures and resource leaks. This makes it difficult to diagnose leftover containers or volumes after a failed run.

Work

  • Replace the bare except BaseException: pass (or equivalent) in the Docker teardown path with structured warning capture — log the exception at WARNING level with enough context (container ID, operation) to diagnose the failure.
  • Ensure the teardown still proceeds past the failed step rather than re-raising, so a single cleanup error does not block the rest of the teardown sequence.
  • Add a test that simulates a teardown failure and asserts the warning is emitted.
Tracked from the medium-priority refactoring playbook in #154. Docker teardown catches `BaseException` and discards it silently, which can hide cleanup failures and resource leaks. This makes it difficult to diagnose leftover containers or volumes after a failed run. ## Work - Replace the bare `except BaseException: pass` (or equivalent) in the Docker teardown path with structured warning capture — log the exception at WARNING level with enough context (container ID, operation) to diagnose the failure. - Ensure the teardown still proceeds past the failed step rather than re-raising, so a single cleanup error does not block the rest of the teardown sequence. - Add a test that simulates a teardown failure and asserts the warning is emitted.
didericis added the Kind/Enhancement label 2026-06-02 23:34:12 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Kind/Enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?