didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

PRD 0046: Remove ExtraHosts from git remotes manifest schema #152

New Issue
Closed
opened 2026-06-02 14:09:47 -04:00 by didericis-codex · 1 comment
didericis-codex commented 2026-06-02 14:09:47 -04:00
Collaborator
Copy Link
Copy Source

Problem

git.remotes.*.ExtraHosts gives the git remote declaration a hosts-file override that can affect resolution outside the intended git-gate use case. That creates surprising behavior for HTTP/API paths that should continue to use normal egress DNS and policy.

Requested Change

Remove ExtraHosts from the git.remotes manifest schema and the git-gate provisioning path. Keep git.remotes focused on the upstream repository declaration and credential/trust material that git-gate actually needs.

Acceptance Criteria

  • Manifest parsing rejects git.remotes.*.ExtraHosts with a clear error.
  • Git-gate prepare/compose/launch no longer emits Docker extra_hosts from git remote declarations.
  • Existing tests that cover ExtraHosts are removed or rewritten to assert rejection.
  • Documentation and examples no longer advertise ExtraHosts.
  • Egress DNS/HTTP behavior is unchanged.
## Problem `git.remotes.*.ExtraHosts` gives the git remote declaration a hosts-file override that can affect resolution outside the intended git-gate use case. That creates surprising behavior for HTTP/API paths that should continue to use normal egress DNS and policy. ## Requested Change Remove `ExtraHosts` from the `git.remotes` manifest schema and the git-gate provisioning path. Keep `git.remotes` focused on the upstream repository declaration and credential/trust material that git-gate actually needs. ## Acceptance Criteria - Manifest parsing rejects `git.remotes.*.ExtraHosts` with a clear error. - Git-gate prepare/compose/launch no longer emits Docker `extra_hosts` from git remote declarations. - Existing tests that cover `ExtraHosts` are removed or rewritten to assert rejection. - Documentation and examples no longer advertise `ExtraHosts`. - Egress DNS/HTTP behavior is unchanged.
didericis commented 2026-06-02 14:12:19 -04:00
Owner
Copy Link
Copy Source

No need to remember that extra hosts used to be in the manifest or add specific errors for it/just nix all the extrahosts stuff

No need to remember that extra hosts used to be in the manifest or add specific errors for it/just nix all the extrahosts stuff
didericis added the Compat/BreakingKind/BugKind/Documentation labels 2026-06-02 14:13:52 -04:00
didericis-codex changed title from Remove ExtraHosts from git remotes manifest schema to PRD 0046: Remove ExtraHosts from git remotes manifest schema 2026-06-02 14:33:36 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Compat/Breaking Kind/Bug Kind/Documentation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#152
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?