didericis/bot-bottle
1
0
Fork 0
Code Issues 7 Pull Requests 15 Actions Packages Projects Releases Wiki Activity

PRD 0034: Sidecar Restart and Shutdown Semantics #127

Merged
didericis merged 3 commits from prd-0034-sidecar-restart-shutdown-semantics into main 2026-06-02 03:55:06 -04:00
Conversation 3 Commits 3 Files Changed 3
+277 -18
didericis-codex commented 2026-06-02 03:43:55 -04:00
Collaborator
Copy Link
Copy Source

Closes #126.

Parent hotspot review: #117.

PRD: fe6059e4a6/docs/prds/0034-sidecar-restart-shutdown-semantics.md

Summary

Implements PRD 0034 by moving SIGUSR1-triggered pipelock restarts onto the sidecar supervisor loop instead of doing restart work directly from the signal handler. Repeated restart requests coalesce by daemon name, and shutdown clears pending restarts so no daemon is respawned during teardown.

Clarifies exit-code behavior so positive child failures remain visible while signal-only shutdown returns zero instead of surfacing platform-specific negative signal codes.

Changes (3 commits)

  • docs(prd): add sidecar restart semantics
  • fix(sidecar): queue restart signals
  • complete(prd): mark PRD 0034 active
Closes #126. Parent hotspot review: #117. PRD: https://gitea.dideric.is/didericis/bot-bottle/src/commit/fe6059e4a67ad540aa2431ab14c48ff07c03e261/docs/prds/0034-sidecar-restart-shutdown-semantics.md ## Summary Implements PRD 0034 by moving SIGUSR1-triggered pipelock restarts onto the sidecar supervisor loop instead of doing restart work directly from the signal handler. Repeated restart requests coalesce by daemon name, and shutdown clears pending restarts so no daemon is respawned during teardown. Clarifies exit-code behavior so positive child failures remain visible while signal-only shutdown returns zero instead of surfacing platform-specific negative signal codes. ## Changes (3 commits) - `docs(prd): add sidecar restart semantics` - `fix(sidecar): queue restart signals` - `complete(prd): mark PRD 0034 active`
didericis-codex added 1 commit 2026-06-02 03:43:56 -04:00
docs(prd): add sidecar restart semantics
test / unit (pull_request) Successful in 42s
Details
test / integration (pull_request) Successful in 59s
Details
1b34b1df85
didericis commented 2026-06-02 03:49:50 -04:00
Owner
Copy Link
Copy Source

RE coalescing, think that makes sense. RE clamping, think that also makes sense.

RE coalescing, think that makes sense. RE clamping, think that also makes sense.
didericis-codex commented 2026-06-02 03:50:28 -04:00
Author
Collaborator
Copy Link
Copy Source

Thanks, I’ll implement those decisions in PRD 0034: repeated restart requests will coalesce by daemon name, and exit-code handling will clamp signal-only shutdown outcomes to 0 while preserving any positive child crash code.

Thanks, I’ll implement those decisions in PRD 0034: repeated restart requests will coalesce by daemon name, and exit-code handling will clamp signal-only shutdown outcomes to 0 while preserving any positive child crash code.
didericis added 2 commits 2026-06-02 03:52:49 -04:00
fix(sidecar): queue restart signals 31708abfad
complete(prd): mark PRD 0034 active
test / unit (pull_request) Successful in 39s
Details
test / integration (pull_request) Successful in 52s
Details
test / unit (push) Successful in 34s
Details
test / integration (push) Successful in 50s
Details
fe6059e4a6
didericis approved these changes 2026-06-02 03:54:59 -04:00
didericis merged commit fe6059e4a6 into main 2026-06-02 03:55:06 -04:00
didericis deleted branch prd-0034-sidecar-restart-shutdown-semantics 2026-06-02 03:55:07 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
didericis
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
didericis-claude (didericis (claude)) didericis-codex (didericis (codex)) didericis-gemma (gemma) didericis
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: didericis/bot-bottle#127
Delete Branch "prd-0034-sidecar-restart-shutdown-semantics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?